Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Parameter definitions deserialiser #48

Merged
merged 3 commits into from
Aug 20, 2018
Merged

Conversation

itowlson
Copy link
Contributor

@itowlson itowlson commented Aug 20, 2018

Reads the ARM parameter definition schema and validates parameter values against it. (Currently does not validate the definitions themselves.)

Fixes #18 and #55.

switch pd.DataType {
case "string":
return pd.validateStringParameterValue(value)
case "int":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice until reading this that there is no float in the ARM template params spec.

Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed. 🚢

@itowlson itowlson merged commit d82f22c into cnabio:master Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants