Skip to content

Conversation

Thaumy
Copy link
Contributor

@Thaumy Thaumy commented Jul 14, 2023

  • 将"保存博文"字样修改为"上传博文", 并修改相关代码命名
  • 为上传博文添加了确认提示

@Thaumy Thaumy requested a review from cnblogs-dudu July 14, 2023 10:16
@Thaumy Thaumy added the feat New features label Jul 14, 2023
@cnblogs-dudu
Copy link
Collaborator

cnblogs-dudu commented Jul 14, 2023

保存博文时报错:

Error running command vscode-cnb.save-post: command 'vscode-cnb.save-post' not found. This is likely caused by the extension that contributes vscode-cnb.save-post.

@cnblogs-dudu
Copy link
Collaborator

cnblogs-dudu commented Jul 14, 2023

package.json#L152 改为上传博文

@Thaumy
Copy link
Contributor Author

Thaumy commented Jul 17, 2023

Fixed

@laggage
Copy link
Contributor

laggage commented Jul 18, 2023

为上传博文添加了确认提示

May be its better to have an option for this, just my opinion :)

@cnblogs-dudu
Copy link
Collaborator

cnblogs-dudu commented Jul 18, 2023

用类似这样下面的对话框,右下角是提示区域,容易不被注意到

1-20230718150652294-223189330

@cnblogs-dudu
Copy link
Collaborator

@laggage this icon and the right one are too small and easy to misclick.

@laggage
Copy link
Contributor

laggage commented Jul 18, 2023

@laggage this icon and the right one are too small and easy to misclick.

@cnblogs-dudu I totally understand and agree the problem you pointed, however, what i mean is someone may just not want to have a confirm before the upload, so may be we can have an option like 'require confirm before upload' for this. This is just my suggestion, the decision it's up to you :)

@Thaumy
Copy link
Contributor Author

Thaumy commented Jul 18, 2023

Maybe it's better to leave a setting option for this feature

@cnblogs-dudu
Copy link
Collaborator

@Thaumy add an option to disable Push confirmation dialog.

@cnblogs-dudu cnblogs-dudu merged commit 8e58ffe into main Jul 26, 2023
@cnblogs-dudu cnblogs-dudu deleted the add-confirm-btn-to-upload-post branch July 26, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants