Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux: based helm install of kepler #17

Merged
merged 1 commit into from
Dec 19, 2023
Merged

flux: based helm install of kepler #17

merged 1 commit into from
Dec 19, 2023

Conversation

dipankardas011
Copy link
Contributor

@dipankardas011 dipankardas011 commented Dec 14, 2023

Solution

References

we need --create-namsepace flag to be true according to the docs

Issue

Note for Reviewer

Do remove the clusters/kube-prometheus.yaml as its been worked on by #12

@dipankardas011 dipankardas011 changed the title resolves #15: flux based helm install of kepler flux based helm install of kepler Dec 14, 2023
@dipankardas011 dipankardas011 changed the title flux based helm install of kepler flux: based helm install of kepler Dec 14, 2023
clusters/kepler.yaml Outdated Show resolved Hide resolved
clusters/kepler.yaml Outdated Show resolved Hide resolved
clusters/kepler.yaml Outdated Show resolved Hide resolved
clusters/kepler.yaml Outdated Show resolved Hide resolved
clusters/kepler.yaml Outdated Show resolved Hide resolved
clusters/kepler.yaml Outdated Show resolved Hide resolved
clusters/kepler.yaml Show resolved Hide resolved
@dipankardas011
Copy link
Contributor Author

@rossf7 the latest Commit makes the flux install kepler in the monitoring namespace due to one issue
Refer: Update-Prometheus, For the service monitor to work

@dipankardas011
Copy link
Contributor Author

To test out

kubectl apply -f clusters/kube-prometheus.yaml
kubectl apply -f clusters/kepler.yaml

kubectl -n monitoring port-forward svc/grafana 3000:3000

to get the dashboard create a new one and paste this https://raw.githubusercontent.com/sustainable-computing-io/kepler/main/grafana-dashboards/Kepler-Exporter.json

to you get this
image

@dipankardas011
Copy link
Contributor Author

@rossf7 the latest Commit makes the flux install kepler in the monitoring namespace due to one issue Refer: Update-Prometheus, For the service monitor to work

May be for now we can try with

services                     []                 []              [get list watch]
endpoints                    []                 []              [get list watch]

clusters/kepler.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dipankardas011 Kepler changes look good and thanks for finding the solution to the scraping problem.

I think we do want Prometheus to be able to scrape services in all namespaces.

@dipankardas011
Copy link
Contributor Author

LGTM

@dipankardas011 Kepler changes look good and thanks for finding the solution to the scraping problem.

I think we do want Prometheus to be able to scrape services in all namespaces.

I was wondering whether we should keep the kube-prometeus yaml which I created as issue #12 is working on that

@rossf7
Copy link
Contributor

rossf7 commented Dec 19, 2023

I was wondering whether we should keep the kube-prometeus yaml which I created as issue #12 is working on that

@dipankardas011 Yes I think it might be easier to remove kube-prometheus.yaml and patch the cluster role in #12

@AntonioDiTuri Is that OK with you?

cc @nikimanoledaki

Copy link
Contributor Author

@dipankardas011 dipankardas011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossf7 completed refactoring the PR you can now merge it

clusters/kepler.yaml Outdated Show resolved Hide resolved
@dipankardas011
Copy link
Contributor Author

Okay let me rebase it

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

now kepler serviceMonitor is visible to promtheus

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

removed the kube-prometheus fluxcd manifest refer pr #12

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>

refactored the comments in the manifest

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
Co-authored-by: Ross Fairbanks <rossf7@users.noreply.github.com>
Co-authored-by: Niki Manoledaki <niki.manoledaki@grafana.com>
@dipankardas011
Copy link
Contributor Author

done 🚀

Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it!!! Thank you @dipankardas011 @rossf7! 🥳

@nikimanoledaki nikimanoledaki merged commit 9b9df68 into cncf-tags:main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Automated] installing kepler using flux
3 participants