-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flux: based helm install of kepler #17
flux: based helm install of kepler #17
Conversation
@rossf7 the latest Commit makes the flux install kepler in the monitoring namespace due to one issue |
To test out kubectl apply -f clusters/kube-prometheus.yaml
kubectl apply -f clusters/kepler.yaml
kubectl -n monitoring port-forward svc/grafana 3000:3000 to get the dashboard create a new one and paste this https://raw.githubusercontent.com/sustainable-computing-io/kepler/main/grafana-dashboards/Kepler-Exporter.json |
May be for now we can try with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dipankardas011 Kepler changes look good and thanks for finding the solution to the scraping problem.
I think we do want Prometheus to be able to scrape services in all namespaces.
I was wondering whether we should keep the kube-prometeus yaml which I created as issue #12 is working on that |
@dipankardas011 Yes I think it might be easier to remove kube-prometheus.yaml and patch the cluster role in #12 @AntonioDiTuri Is that OK with you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossf7 completed refactoring the PR you can now merge it
Okay let me rebase it |
Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> now kepler serviceMonitor is visible to promtheus Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> removed the kube-prometheus fluxcd manifest refer pr #12 Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> refactored the comments in the manifest Signed-off-by: Dipankar Das <dipankardas0115@gmail.com> Co-authored-by: Ross Fairbanks <rossf7@users.noreply.github.com> Co-authored-by: Niki Manoledaki <niki.manoledaki@grafana.com>
done 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it!!! Thank you @dipankardas011 @rossf7! 🥳
Solution
References
we need
--create-namsepace
flag to be true according to the docsIssue
Note for Reviewer
Do remove the
clusters/kube-prometheus.yaml
as its been worked on by #12