test: installing prometheus with flux

[AntonioDiTuri]

Manual test to install prometheus via flux

[nikimanoledaki]

Awesome, thank you for initialising Flux! 🥳

Could you delete ./dev/ to only keep ./clusters/ please?

[nikimanoledaki]

This issue completes Prometheus in Phase 1: Base-level cluster components (MVP) of #5

[AntonioDiTuri]

Done! Could you please accept it so that we can test the prometheus installation via Flux? Or do you think we are missing something else?

[nikimanoledaki]

Thank you @AntonioDiTuri - LGTM!

[nikimanoledaki]

Could you enable GPG and then rebase so that the signed commits show up as verified, please:

The base branch requires all commits to be signed. Learn more about signing commits.

[rossf7]

LGTM 🚀

[dipankardas011]

I found some interesting issues when using kube-prometheus
Here is the messsage #17 (comment)

[dipankardas011]

I found some interesting issues when using kube-prometheus Here is the messsage #17 (comment)

possible solution

https://fluxcd.io/flux/components/kustomize/kustomizations/#patches
https://github.com/prometheus-operator/kube-prometheus/blob/main/manifests/prometheus-clusterRole.yaml

Review Link -> https://github.com/cncf-tags/green-reviews-tooling/pull/17/files#r1431173739

[dipankardas011]

@AntonioDiTuri Can you update the kube-prometheus 😃

[AntonioDiTuri]

I will update this Pull Request in the next week, we need also to move from Kustomize to Helm Release

[rossf7]

@AntonioDiTuri Can you also change the target namespace for kepler to the monitoring namespace? As then we don't need to patch the prometheus cluster role to scrape other namespaces.

green-reviews-tooling/clusters/kepler.yaml

Line 27 in 9b9df68

targetNamespace: kepler

@dipankardas011 This is as you had it originally in your kepler PR and keeps things simpler!

[dipankardas011]

@AntonioDiTuri Can you also change the target namespace for kepler to the monitoring namespace? As then we don't need to patch the prometheus cluster role to scrape other namespaces.

green-reviews-tooling/clusters/kepler.yaml

Line 27 in 9b9df68

targetNamespace: kepler

@dipankardas011 This is as you had it originally in your kepler PR and keeps things simpler!

yup that is one possible solution 👍🏼

[dipankardas011]

yes as we are using kepler like a montiroing tool for our CNCF projects and it fit well in monitoring category

[rossf7]

@AntonioDiTuri Sorry can you also make sure the kube-prometheus-stack helmrelease has these values?

By default it only scrapes the service monitors deployed in the helm release.

  values:
    prometheus:
      prometheusSpec:
        serviceMonitorSelectorNilUsesHelmValues: false

[AntonioDiTuri]

I uploaded the helm release for prometheus with the needed values, regarding the target namespace for kepler I cannot change it in this PR but we can do it in another branch

[AntonioDiTuri]

Helm repo added! Not sure why the merging is blocked, it says all commits need to be signed, and the checks say all commits are signed, I am a bit confused. @nikimanoledaki do you know how to solve this?

[nikimanoledaki]

@AntonioDiTuri they need to be signed and verified e.g. with GPG: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification