-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update labeler.yml to add lang/tw and lang/ja #2024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seokho Son <shsongist@gmail.com>
seokho-son
requested review from
caniszczyk,
CathPag,
JasonMorgan,
iamNoah1 and
jihoon-seo
as code owners
May 12, 2023 06:25
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
PTAL @jihoon-seo @iamNoah1 :) |
seokho-son
added
the
maintainers
Use this label if PR requires maintainers to take action
label
May 12, 2023
jihoon-seo
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CathPag
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aryasoni98
pushed a commit
to aryasoni98/glossary
that referenced
this pull request
Jun 12, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Arya Soni <aryasoni98@gmail.com>
aryasoni98
pushed a commit
to aryasoni98/glossary
that referenced
this pull request
Jun 14, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Arya Soni <aryasoni98@gmail.com>
hwchiu
pushed a commit
to hwchiu/glossary
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update labeler.yml to add lang/tw and lang/ja
Related issue number or link (ex:
resolves #issue-number
)none
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.