Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labeler.yml to add lang/tw and lang/ja #2024

Merged
merged 1 commit into from
May 15, 2023

Conversation

seokho-son
Copy link
Collaborator

Describe your changes

Update labeler.yml to add lang/tw and lang/ja

Related issue number or link (ex: resolves #issue-number)

none

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Seokho Son <shsongist@gmail.com>
@netlify
Copy link

netlify bot commented May 12, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 90b1a29
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/645ddbde6f6da80008e5da8a
😎 Deploy Preview https://deploy-preview-2024--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Collaborator Author

PTAL @jihoon-seo @iamNoah1 :)

@seokho-son seokho-son added the maintainers Use this label if PR requires maintainers to take action label May 12, 2023
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CathPag CathPag merged commit 67789dd into cncf:main May 15, 2023
aryasoni98 pushed a commit to aryasoni98/glossary that referenced this pull request Jun 12, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Arya Soni <aryasoni98@gmail.com>
aryasoni98 pushed a commit to aryasoni98/glossary that referenced this pull request Jun 14, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Arya Soni <aryasoni98@gmail.com>
hwchiu pushed a commit to hwchiu/glossary that referenced this pull request Aug 14, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants