Update permission and add initial approvers for Japanese #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seokho Son <shsongist@gmail.com>
seokho-son
requested review from
caniszczyk,
CathPag,
JasonMorgan,
iamNoah1 and
jihoon-seo
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @inductor @naonishijima @kaitoii11 Please check and confirm following policies :) |
|
Thanks! |
jihoon-seo
added
the
maintainers
jihoon-seo
approved these changes
May 18, 2023
|
Lemme merge this. 😊 |
This was referenced May 21, 2023
aryasoni98
pushed a commit
to aryasoni98/glossary
that referenced
this pull request
Jun 12, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Arya Soni <aryasoni98@gmail.com>
aryasoni98
pushed a commit
to aryasoni98/glossary
that referenced
this pull request
Jun 14, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Arya Soni <aryasoni98@gmail.com>
hwchiu
pushed a commit
to hwchiu/glossary
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Change permission for @iamNoah1 @jihoon-seo from maintain to admin so that the maintainers can merge a PR related with branches
Remove inactive localization approvers
Related issue number or link (ex:
resolves #issue-number)#1422
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".