Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings and initial contents for Japanese localization #2088

Merged
merged 5 commits into from
Jun 2, 2023
Merged

Settings and initial contents for Japanese localization #2088

merged 5 commits into from
Jun 2, 2023

Conversation

naonishijima
Copy link
Collaborator

This PR is to initiate Japanese localization based on

Base and target branch of this PR is dev-ja which is development branch for Japanese localization.

This PR includes

  • [languages.ja] section in config.toml
  • content/ja/ directory
  • i18n/ja.toml
  • Some translated documents
    • Main page
      • content/ja/_index.md
    • Terms
      • "Cloud Computing": content/ja/cloud_computing.md
    • Others
      • contribute: content/ja/contribute/_index.md
      • style-guide: content/ja/style-guide/_index.md

ss

jihoon-seo and others added 4 commits May 15, 2023 03:24
@jihoon-seo
Update lang names in config.toml (cncf#2021)
92bfa52 
Signed-off-by: Jihoon Seo <jihoon.seo@etri.re.kr>
@seokho-son
Update labeler.yml (cncf#2024)
67789dd 
Signed-off-by: Seokho Son <shsongist@gmail.com>
@seokho-son
Update permission and add initial approvers for Japanese (cncf#2046)
54fae70 
Signed-off-by: Seokho Son <shsongist@gmail.com>
@dependabot
Bump rojopolis/spellcheck-github-actions from 0.30.0 to 0.32.0 (cncf#…
d3f75a9 
…2080)

Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.30.0 to 0.32.0.
- [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases)
- [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md)
- [Commits](rojopolis/spellcheck-github-actions@0.30.0...0.32.0)

---
updated-dependencies:
- dependency-name: rojopolis/spellcheck-github-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@netlify
Copy link

netlify bot commented May 24, 2023 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit d526fd8
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/646e9f78a5acf30008e6d4ee
😎 Deploy Preview https://deploy-preview-2088--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo
Copy link
Collaborator

Currently dev-ja is 4 commits behind main,
and this PR is updating dev-ja since this PR contains those 4 commits as-is from main (I mean, keeping the commit hashes as-is).
(Also, the commit 54fae70 from main is the required commit to dev-ja, for Japanese teams to have proper permission in dev-ja as well as in main.)
LGTM for this aspect.

@jihoon-seo
Copy link
Collaborator

@inductor @kaitoii11 please review the Japanese-localized contents in this PR!

jihoon-seo
jihoon-seo reviewed May 24, 2023
View reviewed changes
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naonishijima Could you add glossary/i18n/ja.toml too?
This can be done either in this PR, or in separate PR. IMO either way is fine.

image

content/ja/cloud-computing.md Outdated Show resolved Hide resolved
@inductor
Copy link
Collaborator

DCO is required. You should git commit --signoff and push again.

inductor
inductor reviewed May 24, 2023
View reviewed changes
config.toml Outdated Show resolved Hide resolved
content/ja/_TEMPLATE.md Show resolved Hide resolved
content/ja/cloud-computing.md Outdated Show resolved Hide resolved
content/ja/_index.md Outdated Show resolved Hide resolved
@naonishijima
Settings and initial contents for Japanese localization
d526fd8 
This PR is to initiate Japanese localization based on the issue(cncf#1422).

Signed-off-by: Nao Nishijima <nao.nishijima.xt@hitachi.com>
@jihoon-seo jihoon-seo added the lang/ja for Japanese label May 25, 2023
@naonishijima
Copy link
Collaborator Author

Is there anything I should do from my side?

@inductor
Copy link
Collaborator

inductor commented Jun 2, 2023 •
edited
Loading

@seokho-son I think we also need maintainer's approval since it touches files under project root?

jihoon-seo
jihoon-seo approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for general things!

To who merge this PR: please use 'Create a merge commit' method, not 'Squash and merge' !

@inductor inductor merged commit 7b42e10 into cncf:dev-ja Jun 2, 2023
5 checks passed
@kaitoii11 kaitoii11 mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitoii11 kaitoii11 kaitoii11 approved these changes

@inductor inductor inductor approved these changes

@jihoon-seo jihoon-seo jihoon-seo approved these changes

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@CathPag CathPag Awaiting requested review from CathPag

@JasonMorgan JasonMorgan Awaiting requested review from JasonMorgan

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

@iamNoah1 iamNoah1 Awaiting requested review from iamNoah1 iamNoah1 is a code owner

Assignees
No one assigned
Labels
lang/ja for Japanese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@naonishijima @jihoon-seo @inductor @kaitoii11 @seokho-son