-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add design proposal template #37
Conversation
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Sorry I messed up the first PR (#35). I have flagged this for review from the governance WG and our TOC liaisons. @jberkus or @geekygirldawn Can you ping our liaisons for review? |
@geekygirldawn do you know what the next steps I need to do for this PR are? |
Sorry about this - I think it fell through the cracks in the run up to KubeCon :( I'm thinking that maybe it shouldn't be named GOVERNANCE-design-proposals.md, but maybe instead called DESIGN-PROPOSALS.md, since it's not really part of the GOVERNANCE.md file. The other files called GOVERNANCE-something.md @jberkus did you have any thoughts before this goes to our liaisons for approval? Also, I know that @jberkus is at a conference this week, so we may need to catch up with him next week for this one. |
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
No worries, totally understand that! I've updated the file name and will wait for @jberkus to comment when he is back from the conference |
Added one suggestion; the rest looks good to go. |
Co-authored-by: Josh Berkus <josh@agliodbs.com> Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Good point, I've included that now |
Looks good, I'll ping our CNCF liasons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've provided a lot of comments, some are pure suggestions, some are proposed rewrites to improve clarity or robustness of the desired content - they're not required as i want to ensure i understand the intent in those areas and leave that to the authors to confirm, clarify, or reject.
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted my suggestions based on @dzolotusky 's comments. Dave, please take a second look to see if the suggestions would resolve your comments. @jberkus @xmulligan please also review as this is based on our understanding of the content presented, which may not align with the original intent.
@xmulligan based on the feedback above, I think this template is going to need an accompanying documentation to be useful. Was that something you'd started on, or do we need to recruit someone else for that? |
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one explanation on the checklist and this will be good to go for me
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@jberkus @geekygirldawn is there anything else I need to do to get this merged? |
@dzolotusky @TheFoxAtWork is this good enough now? |
You've got my approval. |
@dzolotusky - are you with these changes? |
Yes, this looks good to me now. Sorry for taking so long to get back to you here. |
@amye @TheFoxAtWork - this PR is done, so if one of you could merge it, that would be great! |
@geekygirldawn , GitHub is showing you have an outstanding action to review and approve this pull request. I am also not authorized to merge it. Once you review and approve, @amye should be able to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your hard work on this!
fixing #35