Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add design proposal template #37

Merged
merged 7 commits into from
Aug 4, 2023
Merged

add design proposal template #37

merged 7 commits into from
Aug 4, 2023

Conversation

xmulligan
Copy link
Contributor

@xmulligan xmulligan commented Mar 30, 2023

fixing #35

Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@carolynvs
Copy link
Contributor

Sorry I messed up the first PR (#35). I have flagged this for review from the governance WG and our TOC liaisons. @jberkus or @geekygirldawn Can you ping our liaisons for review?

@xmulligan
Copy link
Contributor Author

@geekygirldawn do you know what the next steps I need to do for this PR are?

@geekygirldawn
Copy link
Member

Sorry about this - I think it fell through the cracks in the run up to KubeCon :(

I'm thinking that maybe it shouldn't be named GOVERNANCE-design-proposals.md, but maybe instead called DESIGN-PROPOSALS.md, since it's not really part of the GOVERNANCE.md file. The other files called GOVERNANCE-something.md
are meant to be customized and used as GOVERNANCE.md.

@jberkus did you have any thoughts before this goes to our liaisons for approval?

Also, I know that @jberkus is at a conference this week, so we may need to catch up with him next week for this one.

Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@xmulligan
Copy link
Contributor Author

No worries, totally understand that! I've updated the file name and will wait for @jberkus to comment when he is back from the conference

@jberkus
Copy link
Collaborator

jberkus commented Jun 5, 2023

Added one suggestion; the rest looks good to go.

Co-authored-by: Josh Berkus <josh@agliodbs.com>
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@xmulligan
Copy link
Contributor Author

Good point, I've included that now

@jberkus
Copy link
Collaborator

jberkus commented Jun 7, 2023

Looks good, I'll ping our CNCF liasons.

Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've provided a lot of comments, some are pure suggestions, some are proposed rewrites to improve clarity or robustness of the desired content - they're not required as i want to ensure i understand the intent in those areas and leave that to the authors to confirm, clarify, or reject.

DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted my suggestions based on @dzolotusky 's comments. Dave, please take a second look to see if the suggestions would resolve your comments. @jberkus @xmulligan please also review as this is based on our understanding of the content presented, which may not align with the original intent.

@jberkus
Copy link
Collaborator

jberkus commented Jun 12, 2023

@xmulligan based on the feedback above, I think this template is going to need an accompanying documentation to be useful. Was that something you'd started on, or do we need to recruit someone else for that?

Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
DESIGN-PROPOSALS.md Outdated Show resolved Hide resolved
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one explanation on the checklist and this will be good to go for me

DESIGN-PROPOSALS.md Show resolved Hide resolved
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@xmulligan
Copy link
Contributor Author

@jberkus @geekygirldawn is there anything else I need to do to get this merged?

@jberkus
Copy link
Collaborator

jberkus commented Jul 28, 2023

@dzolotusky @TheFoxAtWork is this good enough now?

@TheFoxAtWork
Copy link
Contributor

You've got my approval.

@geekygirldawn
Copy link
Member

@dzolotusky - are you with these changes?

@dzolotusky
Copy link

@dzolotusky - are you with these changes?

Yes, this looks good to me now.

Sorry for taking so long to get back to you here.

@geekygirldawn
Copy link
Member

@amye @TheFoxAtWork - this PR is done, so if one of you could merge it, that would be great!

@TheFoxAtWork
Copy link
Contributor

@geekygirldawn , GitHub is showing you have an outstanding action to review and approve this pull request. I am also not authorized to merge it. Once you review and approve, @amye should be able to merge.

Copy link
Member

@geekygirldawn geekygirldawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your hard work on this!

@amye amye merged commit 54a33f5 into cncf:main Aug 4, 2023
@xmulligan xmulligan deleted the patch-2 branch August 17, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants