Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kyverno security self assessment #852

Merged
merged 23 commits into from
Mar 25, 2022
Merged

Conversation

JimBugwadia
Copy link
Contributor

cc: @jlk

JimBugwadia and others added 10 commits June 2, 2021 23:16
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
@JimBugwadia
Copy link
Contributor Author

@lumjjb
Copy link
Contributor

lumjjb commented Feb 5, 2022

This is awesome! We'll do a short "clarifying questions" phase review on this just to clarify on some points (if needed) and we'll can merge it in!

Part of this phase is to do the following:

  • Verify completeness
  • Ask for clarifications
  • Ensure terms are defined
  • Ensure concepts introduced are explained with context
  • Provide quick feedback

@lumjjb lumjjb self-assigned this Feb 5, 2022
@lumjjb lumjjb added this to the STAG Rep: @lumjjb milestone Feb 5, 2022
@fkautz
Copy link
Contributor

fkautz commented Feb 7, 2022

Please include me

@dutchshark
Copy link
Contributor

dutchshark commented Feb 8, 2022

interested in helping out.

After a chat with Brandon on this PR - I've read up on https://github.com/cncf/tag-security/blob/main/assessments/guide/self-assessment.md - I'm missing some elements in this one:
Languages which I would address as Go and the SBOM shouldn't this match up with https://kyverno.io/docs/installation/ and the Compatability Matrix?

@dutchshark
Copy link
Contributor

For discussion tonight with @lumjjb:
kyverno/kyverno#2950 (comment) as this would mean vulnerability in their used logger (which should be part of the SBOM) exists two CVE's are hit.

@dutchshark
Copy link
Contributor

Hard conflicts:
Reviewer is a maintainer of the project - NO
Reviewer is a direct report of/to a maintainer of the project - NO
Reviewer is paid to work on the project - NO
Reviewer has significant financial interest directly tied to success of the project - NO

Soft conflicts:
Reviewer belongs to the same company/organization of the project, but does not work on the project - NO
Reviewer uses the project in his/her work - NO
Reviewer has contributed to the project. - NO
Reviewer has a personal stake in the project (personal relationships, etc.) - NO

@JimBugwadia
Copy link
Contributor Author

Thanks @dutchshark!

I've read up on https://github.com/cncf/tag-security/blob/main/assessments/guide/self-assessment.md - I'm missing some elements in this one

Are there other sections or information you recommend we add to the self-assessment?

Languages which I would address as Go and the SBOM shouldn't this match up with https://kyverno.io/docs/installation/[](https://github.com/JimBugwadia) and the Compatability Matrix?

Kyverno uses Golang but is delivered as a container image and manifests. The available installation are options are via a Helm chart or YAMLs.

The Security page provides a link to the SBOM. We can reference in the installation as well.

@dutchshark
Copy link
Contributor

dutchshark commented Feb 10, 2022

You're welcome @JimBugwadia - I'm only here to help;

Are there other sections or information you recommend we add to the self-assessment?

I think the initial self-assessment is providing that what tag-security needs and the more details provided the better. Hence my comments around the adding of the SBOM to your self-assessment.

The Security page provides a link to the SBOM.

If you could put it on your self-assessment that would be great.

@lumjjb lumjjb added the assessment project security assessments (one issue per project) label Feb 16, 2022
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , added wesley as another reviewer

assessments/projects/kyverno/self-assessment.md Outdated Show resolved Hide resolved
Co-authored-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb lumjjb merged commit 885f091 into cncf:main Mar 25, 2022
Michael-Susu12138 pushed a commit to Michael-Susu12138/tag-security that referenced this pull request Dec 12, 2023

Signed-off-by: Jim Bugwadia <jim@nirmata.com>

* updates for self-assessment

Signed-off-by: Jim Bugwadia <jim@nirmata.com>

* address comments from John

Signed-off-by: Jim Bugwadia <jim@nirmata.com>

* fix sp

Signed-off-by: Jim Bugwadia <jim@nirmata.com>

* fix double @

Signed-off-by: Jim Bugwadia <jim@nirmata.com>

* cspell disable names

Signed-off-by: Jim Bugwadia <jim@nirmata.com>

* Add SBOM and metadata in self-assessment

Signed-off-by: Shubham Gupta <shubham.gupta2956@gmail.com>

* Update SBOM fetching link

Signed-off-by: Shubham Gupta <shubham.gupta2956@gmail.com>

* Update assessments/projects/kyverno/self-assessment.md

Co-authored-by: Shuting Zhao <shutting06@gmail.com>
Co-authored-by: Shubham Gupta <shubham.gupta2956@gmail.com>
Co-authored-by: Brandon Lum <lumjjb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assessment project security assessments (one issue per project)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants