Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Go 1.11 with GO111MODULES=on #23

Closed
gnossen opened this issue Mar 13, 2020 · 0 comments · Fixed by #24
Closed

Support for Go 1.11 with GO111MODULES=on #23

gnossen opened this issue Mar 13, 2020 · 0 comments · Fixed by #24

Comments

@gnossen
Copy link

gnossen commented Mar 13, 2020

It seems that #8 introduced a hard dependency on Go 1.13. 1.12 is still supported by the Go language team. And while 1.11 is no longer supported, it is still critical for environments like appengine, which have not yet dropped support. I ran into this problem while trying to compile grpcurl with Go 1.11 (PR):

go test -race ./...
go build golang.org/x/sys/unix: module requires Go 1.12
go build github.com/cncf/udpa/go/udpa/annotations: module requires Go 1.13
go build github.com/envoyproxy/go-control-plane/envoy/annotations: module requires Go 1.12
go build github.com/envoyproxy/go-control-plane/envoy/type: module requires Go 1.12
FAIL	github.com/fullstorydev/grpcurl [build failed]
FAIL	github.com/fullstorydev/grpcurl/cmd/grpcurl [build failed]
Makefile:82: recipe for target 'test' failed

There seems to be a general problem with the Go tooling auto-inserting hard dependencies like this when none was intended by the author. Is that the case here? Or is there some feature that the library truly does depend on in Go 1.13+?

CC @kyessenov
CC @htuch

@htuch htuch closed this as completed in #24 Mar 13, 2020
htuch pushed a commit that referenced this issue Mar 13, 2020
Fixes #23
Tested with go1.11 build ./...

Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant