Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Workflow Infrastructure Kubernetes CRD Integration #131

Merged
merged 2 commits into from
Jan 18, 2020

Conversation

salaboy
Copy link
Contributor

@salaboy salaboy commented Dec 30, 2019

This PR reflects what is described in this issue: #130

This provides an initial version of a Kubernetes CRD to be used as an API for different cloud providers to integrate with Workflows.

@tsurdilo
Copy link
Collaborator

tsurdilo commented Jan 7, 2020

I'm fine with us adding this as salaboy mentioned it may help drive community contributions in that area.

LGTM

@salaboy
Copy link
Contributor Author

salaboy commented Jan 17, 2020

@cathyhongzhang any thoughts about this?
@tsurdilo do we need more review on this?
I am working on a demo for this to explain how things fit together.

@tsurdilo
Copy link
Collaborator

@salaboy I am ok with merging this, was just waiting for anyone else to have the chance to comment. Let's give it one more day and I'll merge. Is that ok with you ?

@tsurdilo tsurdilo merged commit 1e2b416 into cncf:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants