Installation script #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butjar
reviewed
Apr 15, 2019
|
You could add the keyword |
👍 ... maybe add a Vagrantfile to the project |
butjar
reviewed
Apr 15, 2019
butjar
reviewed
Apr 15, 2019
butjar
reviewed
Apr 15, 2019
|
Besides from the setuptools version problem the scripts work like a charm ( |
jadinm
force-pushed
the
install-script
branch
3 times, most recently
from
7662edf
to
812f22d
Compare
butjar
reviewed
Apr 15, 2019
butjar
reviewed
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an installation script in Python.
It will be more readable than a bash script if it grows in the future and it is easier to support multiple discributions.
For the moment, Ubuntu, Debian and Fedora work with this script.
There is also a provisioning script for an Ubuntu 16.04 VM adapted from PR #24 to use the installation script.
A vagrant box was generated.