Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate package.json #1257

Closed
jayvdb opened this issue Jan 4, 2017 · 0 comments
Closed

Generate package.json #1257

jayvdb opened this issue Jan 4, 2017 · 0 comments
Assignees

Comments

@jayvdb
Copy link
Member

jayvdb commented Jan 4, 2017

Each coala bear that uses Node.js should include a NpmRequirement to describe any Node dependencies.

For example, TSLintBear includes:

REQUIREMENTS = {NpmRequirement('tslint', '3')}

package.json also includes "tslint": "~3".
This is unnecessary duplication, and the task is to remove that duplication, or ensure the two versions are consistent.

This task is to create a script, or modify .ci/generate_requirements.py, which is run after coala-bears is installed and writes a new package.json using the NpmRequirement information in the bears.

There may be some extra entries in package.json ; a template .ci/package.json should be used, preferably using jinja template language, to hold extra content for the real package.json.

@rultor rultor closed this as completed in fbb50a5 Jan 21, 2017
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
To avoid duplication and mainitaining consistency of
version of npm packages used in bears and those in the
package.json.
- Add template file .ci/package.json.jinja2 and write
  the main package.json according to the
  npm requirements of the bears.
- Add check in travis.yml for the changes in package.json
- Update the existing package.json to match the one
  generated by this code (in alphabetical order)
- Add remark-lint package meta data to Markdown Bear,
  typescript package to TSLint Bear, babel-eslint and
  eslint-plugin-import package to the ESLint Bear

Closes coala#1257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants