-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageCompressionBear #1259
Comments
ooh that's cool :) |
though we don't have support for binary files yet, it was planned that |
The Also, as this would be a linter bear, a file proxy would be irrelevant. |
I have created a GCI task for this : https://codein.withgoogle.com/tasks/4815242129309696/ (unpublished) |
we could change behaviour of class FileProxy:
...
@property
def raw(self):
"""bytes object"""
return self._raw |
and still maintaining a universal-newline version^^ |
FWIW if we use optimage there won't be the possibility of using the coala in-memory files because omtimage works a lot with the file system directly. |
and yes right, have forgotten that fact... |
ImageCompressionBear is a bear uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
coala's |
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
git-lint
(coala/meta#59) has a few linters for file formats that are not supported by coala, especially non-optional image compression detection for PNG and JPEG.They are built using shell scripts that can be found in https://github.com/sk-/git-lint/tree/master/scripts/custom_linters , wrapping commonly used binaries.
jpegtran-linter.sh
:The file size can be losslessly reduced from $origsize to $newsize bytes. ($reduction% filesize reduction)
optipng-linter.sh
:The file size can be losslessly reduced from $origsize to $newsize bytes. ($reduction% filesize reduction)
pngcrush-linter
:The file size can be losslessly reduced from $origsize to $newsize bytes. ($reduction% filesize reduction)
There are two python libraries which provide this type of functionality.
The latter is by the same author as git-lint, so probably much better for our needs (and it does use more binaries to attempt to reduce the size of the image).
This is a medium difficulty bear proposal, as it works on binary file formats, which is not typical for coala and will likely cause some interesting problems to be solved.
The text was updated successfully, but these errors were encountered: