-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InvalidLinkBear fails on URLs in Markdown link display text and target #1338
Comments
The exact line in the markdown file was However coala output was
|
what's the source line? |
This was found as part of CI1 (See spreadsheet). https://github.com/harelba/q is the repo. The line is https://github.com/harelba/q/blame/master/README.markdown#L6 The problem is the second url in |
I think we need to start looking beyond managing a complex regex internally. |
@jayvdb I used
in .travis.yml file. I used http://coala.readthedocs.io/en/latest/Users/Docker_Image.html#coala-on-travis-ci this link. because generally in markdown files we use So ideally we should do a match with second url and not first right ? |
for reference go to regex101.com and use this as regex This may be helpful in understanding the changes I made in my PR |
Resolve matching for url of type "[valid_url](valid_url)" Fixes coala#1338
[http://harelba.github.io/q/](http://harelba.github.io/q/)
Markdown files have links generally in this form...
InvalidLinkBear
[http://harelba.github.io/q/](http://harelba.github.io/q/)
takes this as a link to checkHowever it should only check
http://harelba.github.io/q/
The text was updated successfully, but these errors were encountered: