Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vulture as a library rather than as a command line tool in VultureBear #1805

Closed
RJ722 opened this issue Jun 3, 2017 · 8 comments · Fixed by #1814
Closed

Use vulture as a library rather than as a command line tool in VultureBear #1805

RJ722 opened this issue Jun 3, 2017 · 8 comments · Fixed by #1814
Labels
difficulty/medium

Comments

@RJ722
Copy link
Member

RJ722 commented Jun 3, 2017 •
edited
Loading

Currently, VultureBear executes vulture as follows:

stdout_output, _ = run_shell_command(
        (self.EXECUTABLE,) +
        tuple(filename for filename in self.file_dict.keys()),
        cwd=self.get_config_dir())

vulture's utility can also be harnessed directly through vulture.scavenge - This would be optimal as it would save time of memory copying.

Reference:
@jayvdb
Copy link
Member

jayvdb commented Jun 3, 2017

Probably a good idea to add Appveyor CI testing on vulture, to avoid any regressions from switching from Win32 command execution to python package loading.

@RJ722 RJ722 mentioned this issue Jun 5, 2017
Closed
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 5, 2017
VultureBear: Make use of the vulture API
f12f9ab 
Refactor VultureBear so that it harnesses vulture
as an API rather than as a command line tool.

Closes: coala#1805
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 5, 2017
VultureBear: Make use of the vulture API
cd1d534 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
@RJ722 RJ722 mentioned this issue Jun 5, 2017
Merged
2 tasks
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 5, 2017
VultureBear: Make use of the vulture API
993f473 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 5, 2017
VultureBear: Make use of the vulture API
8cca109 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
@jendrikseipp
Copy link

@jayvdb I guess you mean using appveyor for testing VultureBear, right?

RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 6, 2017
VultureBear: Make use of the vulture API
5326982 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 8, 2017
@RJ722
VultureBear: Make use of the vulture API
d47f413 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 8, 2017
@RJ722
VultureBear: Make use of the vulture API
4f76df7 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 8, 2017
@RJ722
VultureBear: Make use of the vulture API
346eac5 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
@RJ722
Copy link
Member Author

RJ722 commented Jun 10, 2017

@jayvdb I guess you mean using appveyor for testing VultureBear, right?

Nope, I confirmed!

@jendrikseipp
Copy link

Can you clarify, please? What exactly should be tested with appveyor?

RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 12, 2017
@RJ722
VultureBear: Make use of the vulture API
352ea18 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 12, 2017
@RJ722
VultureBear: Make use of the vulture API
1d7f619 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
@Makman2
Copy link
Member

Makman2 commented Jun 13, 2017 •
edited
Loading

I think he meant we should encourage the guys from vulture to run tests also on AppVeyor for Windows for vulture itself^^ Misunderstood myself^^

@Makman2
Copy link
Member

Makman2 commented Jun 13, 2017

Could be made into a new issue though (encouraging vulture to introduce AppVeyor tests)^^

@Makman2
Copy link
Member

Makman2 commented Jun 13, 2017

@RJ722 please assign yourself if you are working on the issue 👍

RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 13, 2017
@RJ722
VultureBear: Make use of the vulture API
23e8854 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 13, 2017
@RJ722
VultureBear: Make use of the vulture API
23ab8d4 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
RJ722 pushed a commit to RJ722/coala-bears that referenced this issue Jun 13, 2017
@RJ722
VultureBear: Make use of the vulture API
7f3fe6f 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
@Makman2
Copy link
Member

Makman2 commented Jun 14, 2017

@jendrikseipp I haven't seen that you are actually the owner of vulture 😅

Monal5031 pushed a commit to Monal5031/coala-bears that referenced this issue Jun 14, 2017
@Monal5031
VultureBear: Make use of the vulture API
65b2ec8 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@RJ722
VultureBear: Make use of the vulture API
4093082 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
umeshksingla pushed a commit to umeshksingla/coala-bears that referenced this issue Sep 2, 2017
@umeshksingla
VultureBear: Make use of the vulture API
ee73d57 
Refactor VultureBear to make use of the vulture
API rather than using it as a command line tool.

Closes: coala#1805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/medium
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VultureBear: Make use of the vulture API RJ722/coala-bears
4 participants
@jayvdb @jendrikseipp @Makman2 @RJ722