Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LocalBearTestHelper robust #36

Closed
sils opened this issue Feb 21, 2016 · 9 comments
Closed

Make LocalBearTestHelper robust #36

sils opened this issue Feb 21, 2016 · 9 comments

Comments

@sils
Copy link
Member

sils commented Feb 21, 2016

From @AbdealiJK on December 8, 2015 13:31

Currently, LocalBearTestHelper simply checks if there are results that are yielded or not.
Would be considerably better is we give it a list of line, cols where the result should yield in a given file.

Copied from original issue: coala/coala#1111

@sils
Copy link
Member Author

sils commented Feb 21, 2016

@AbdealiJK I think we should support both, it's nice to have those simple tests sometimes IMO

@sils
Copy link
Member Author

sils commented Feb 21, 2016

From @AbdealiJK on December 8, 2015 13:59

Yes, i meant it as an optional thing

On Tue, Dec 8, 2015 at 7:18 PM, Lasse Schuirmann notifications@github.com
wrote:

@AbdealiJK https://github.com/AbdealiJK I think we should support both,
it's nice to have those simple tests sometimes IMO


Reply to this email directly or view it on GitHub
coala/coala#1111 (comment)
.

@sils
Copy link
Member Author

sils commented Feb 21, 2016

The helper should also create the actual files so it can be used well with linters that use file input.

@SanketDG
Copy link
Member

What would be the best way to specify the line and column numbers for each invalid file?

@AbdealiLoKo
Copy link
Contributor

Simple list of line,col tuple?

-----Original Message-----
From: "Sanket Dasgupta" notifications@github.com
Sent: ‎27-‎03-‎2016 10:19
To: "coala-analyzer/coala-bears" coala-bears@noreply.github.com
Cc: "AbdealiJK" abdealikothari@gmail.com
Subject: Re: [coala-bears] Make LocalBearTestHelper robust (#36)

What would be the best way to specify the line and column numbers for each invalid file?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@SanketDG
Copy link
Member

So something like:

    valid_files=(valid_xml_file, valid_xml_chars),
    invalid_files=(invalid_xml_file, invalid_xml_chars),
    positions=([(start_line, end_line, start_col, end_col), ...], [....])

@abhay-raizada
Copy link
Member

@SanketDG @AbdealiJK i have an assertRange function in #227 's tests that does exaclty this, you might want to have a look at that

@Makman2
Copy link
Member

Makman2 commented Mar 27, 2016

I think we should check against Results, then we can check for everything yielded, like severity etc.

@abhay-raizada
Copy link
Member

This issue was moved to coala/coala#2862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants