Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Require coala 0.9.1+ #1243

Merged
merged 2 commits into from
Jan 2, 2017

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Jan 2, 2017

coala-bears 0.9 should not be used with coala 0.10

@gitmate-bot
Copy link
Collaborator

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

coala-bears 0.9 should not be used with coala 0.10
@jayvdb jayvdb added this to the 0.9.2 milestone Jan 2, 2017
@sils
Copy link
Member

sils commented Jan 2, 2017

ack aa76d08

(For the release we'll switch that to 0.10 anyways, this is actually a good sign, we didn't break API in coala and the bears this release yet :) latest with @Makman2 's changes we'll have to upgrade to 0.10 or 11 dependent on whats the newest then)

@jayvdb
Copy link
Member Author

jayvdb commented Jan 2, 2017

The requirement could also be 0.9.0+ , but I expect we'll at least coala 0.9.1 for UnknownLanguage due to #1100

radon 1.4.2 added a dependency on flake8-polyfill, which depends
on flake8 without any version specification, and flake8 versions
have various version dependencies on pyflakes and pycodestyle.
As a result, it is not possible to know what versions of pyflakes
and pycodestyle that will be required to be compatible with
whatever flake8 version happens to be installed.

Fixes coala#1228
@Nosferatul
Copy link
Member

ack 120bed0

@jayvdb
Copy link
Member Author

jayvdb commented Jan 2, 2017

@rultor merge

@rultor
Copy link

rultor commented Jan 2, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link

rultor commented Jan 2, 2017

@rultor merge

@jayvdb Oops, I failed. You can see the full log here (spent 1min)

copying build/lib/bears/scala/scalastyle_config.xml -> build/bdist.linux-x86_64/wheel/bears/scala
creating build/bdist.linux-x86_64/wheel/bears/scss
copying build/lib/bears/scss/__init__.py -> build/bdist.linux-x86_64/wheel/bears/scss
copying build/lib/bears/scss/SCSSLintBear.py -> build/bdist.linux-x86_64/wheel/bears/scss
creating build/bdist.linux-x86_64/wheel/bears/shell
copying build/lib/bears/shell/ShellCheckBear.py -> build/bdist.linux-x86_64/wheel/bears/shell
copying build/lib/bears/shell/__init__.py -> build/bdist.linux-x86_64/wheel/bears/shell
creating build/bdist.linux-x86_64/wheel/bears/sql
copying build/lib/bears/sql/__init__.py -> build/bdist.linux-x86_64/wheel/bears/sql
copying build/lib/bears/sql/SQLintBear.py -> build/bdist.linux-x86_64/wheel/bears/sql
creating build/bdist.linux-x86_64/wheel/bears/swift
copying build/lib/bears/swift/TailorBear.py -> build/bdist.linux-x86_64/wheel/bears/swift
copying build/lib/bears/swift/__init__.py -> build/bdist.linux-x86_64/wheel/bears/swift
creating build/bdist.linux-x86_64/wheel/bears/typescript
copying build/lib/bears/typescript/__init__.py -> build/bdist.linux-x86_64/wheel/bears/typescript
copying build/lib/bears/typescript/TSLintBear.py -> build/bdist.linux-x86_64/wheel/bears/typescript
creating build/bdist.linux-x86_64/wheel/bears/vcs
copying build/lib/bears/vcs/__init__.py -> build/bdist.linux-x86_64/wheel/bears/vcs
creating build/bdist.linux-x86_64/wheel/bears/vcs/git
copying build/lib/bears/vcs/git/__init__.py -> build/bdist.linux-x86_64/wheel/bears/vcs/git
copying build/lib/bears/vcs/git/GitCommitBear.py -> build/bdist.linux-x86_64/wheel/bears/vcs/git
creating build/bdist.linux-x86_64/wheel/bears/verilog
copying build/lib/bears/verilog/__init__.py -> build/bdist.linux-x86_64/wheel/bears/verilog
copying build/lib/bears/verilog/VerilogLintBear.py -> build/bdist.linux-x86_64/wheel/bears/verilog
creating build/bdist.linux-x86_64/wheel/bears/vhdl
copying build/lib/bears/vhdl/VHDLLintBear.py -> build/bdist.linux-x86_64/wheel/bears/vhdl
copying build/lib/bears/vhdl/__init__.py -> build/bdist.linux-x86_64/wheel/bears/vhdl
creating build/bdist.linux-x86_64/wheel/bears/vimscript
copying build/lib/bears/vimscript/__init__.py -> build/bdist.linux-x86_64/wheel/bears/vimscript
copying build/lib/bears/vimscript/VintBear.py -> build/bdist.linux-x86_64/wheel/bears/vimscript
creating build/bdist.linux-x86_64/wheel/bears/xml2
copying build/lib/bears/xml2/__init__.py -> build/bdist.linux-x86_64/wheel/bears/xml2
copying build/lib/bears/xml2/XMLBear.py -> build/bdist.linux-x86_64/wheel/bears/xml2
creating build/bdist.linux-x86_64/wheel/bears/yml
copying build/lib/bears/yml/__init__.py -> build/bdist.linux-x86_64/wheel/bears/yml
copying build/lib/bears/yml/RAMLLintBear.py -> build/bdist.linux-x86_64/wheel/bears/yml
copying build/lib/bears/yml/YAMLLintBear.py -> build/bdist.linux-x86_64/wheel/bears/yml
copying build/lib/bears/VERSION -> build/bdist.linux-x86_64/wheel/bears
running install_egg_info
Copying coala_bears.egg-info to build/bdist.linux-x86_64/wheel/coala_bears-0.9.1.dev20170102202535-py3.4.egg-info
running install_scripts
creating build/bdist.linux-x86_64/wheel/coala_bears-0.9.1.dev20170102202535.dist-info/WHEEL
Uploading distributions to https://pypi.python.org/pypi
Uploading coala_bears-0.9.1.dev20170102202535-py3-none-any.whl
Uploading distributions to https://pypi.python.org/pypi
Uploading coala-bears-0.9.1.dev20170102202535.tar.gz
+ mv /home/r/repo .
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin release/0.9
remote: error: GH006: Protected branch update failed for refs/heads/release/0.9.        
remote: error: Required status check "review/gitmate/manual" is pending.        
To git@github.com:coala/coala-bears.git
 ! [remote rejected] release/0.9 -> release/0.9 (protected branch hook declined)
error: failed to push some refs to 'git@github.com:coala/coala-bears.git'
container ce0cd07f3f49d813e8d7eaf46ea886040c3392ce0a2d704c205e26066fdb7119 is dead
Mon Jan  2 20:26:42 UTC 2017

@jayvdb
Copy link
Member Author

jayvdb commented Jan 2, 2017

reack aa76d08

1 similar comment
@sils
Copy link
Member

sils commented Jan 2, 2017

reack aa76d08

@sils
Copy link
Member

sils commented Jan 2, 2017

ack 120bed0

@jayvdb
Copy link
Member Author

jayvdb commented Jan 2, 2017

@rultor merge

@rultor
Copy link

rultor commented Jan 2, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 120bed0 into coala:release/0.9 Jan 2, 2017
@rultor
Copy link

rultor commented Jan 2, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 1min)

@jayvdb jayvdb deleted the 0.9-use-coala-0.9.1 branch January 2, 2017 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants