HTTPSBear.py: New Bear Added #2063

stellargo · 2017-10-03T09:59:06Z

HTTPS bear can detect URL links which can be changed to https
from http and allows to change them automatically.

Closes #1900

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

gitmate-bot · 2017-10-03T09:59:28Z

bears/general/HTTPSBear.py

+        """
+        for result in dependency_results.get(URLBear.name, []):
+            line_number, link, code, context = result.contents
+            if (link[0:5]!='https'):


The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmps3czyfyb/bears/general/HTTPSBear.py +++ b/tmp/tmps3czyfyb/bears/general/HTTPSBear.py @@ -61,7 +61,7 @@ """ for result in dependency_results.get(URLBear.name, []): line_number, link, code, context = result.contents - if (link[0:5]!='https'): + if (link[0:5] != 'https'): httpslink = 'https' + link[4:] host = urlparse(httpslink).netloc network_timeout = {urlparse(url).netloc

gitmate-bot · 2017-10-03T09:59:29Z

bears/general/HTTPSBear.py

+        """
+        for result in dependency_results.get(URLBear.name, []):
+            line_number, link, code, context = result.contents
+            if (link[0:5]!='https'):


E225 missing whitespace around operator

Origin: PycodestyleBear (E225), Section: autopep8.

Makman2 · 2017-10-03T12:51:47Z

bears/general/HTTPSBear.py

+#     def __init__(self, origin, affected_code,
+#                  link: str,
+#                  http_status_code: (int, None),
+#                  link_context: LINK_CONTEXT):


commented code ;)

@Makman2 Yeah still working on it :P I still have to write tests and get it to solve the problem on its own , also remove unnecessary imports :P

Makman2 · 2017-10-03T12:51:58Z

bears/general/HTTPSBear.py

+
+from coalib.bears.LocalBear import LocalBear
+from dependency_management.requirements.PipRequirement import PipRequirement
+from coalib.bearlib import deprecate_settings


unused import

Makman2 · 2017-10-03T12:52:24Z

bears/general/HTTPSBear.py

+
+from coalib.bears.LocalBear import LocalBear
+from dependency_management.requirements.PipRequirement import PipRequirement
+from coalib.bearlib import deprecate_settings


Generally many unused imports...

Makman2 · 2017-10-03T12:53:34Z

bears/general/HTTPSBear.py

+                                 '{url}').format(url=link),
+                        file=filename,
+                        line=line_number,
+                        severity=RESULT_SEVERITY.NORMAL)


we definitely want a patch ;)

Makman2 · 2017-10-03T12:55:27Z

bears/general/HTTPSBear.py

+                    yield Result.from_values(
+                        origin=self,
+                        message=('You could use https instead of http at - '
+                                 '{url}').format(url=link),


with a patch you don't have to include the link in the message ;)

Makman2 · 2017-10-03T12:56:57Z

bears/general/HTTPSBear.py

+        all your data.
+
+        :param dependency_results: Results given by URLBear.
+        :param follow_redirects: Set to true to autocorrect redirects.


-->

:param a: ABC :param b: DEF

Makman2 · 2017-10-03T13:00:54Z

bears/general/HTTPSBear.py

+    BEAR_DEPS = {URLBear}
+
+    def run(self, filename, file, dependency_results=dict(),
+            follow_redirects: bool=False,


unused parameter

Makman2 · 2017-10-03T13:01:11Z

bears/general/HTTPSBear.py

+                                                else network_timeout.get('*')
+                                                if '*' in network_timeout
+                                                else URLBear.DEFAULT_TIMEOUT
+                                                )


bad indent ;)

gitmate-bot · 2017-10-12T09:34:03Z

bears/general/HTTPSBear.py

+                    end = start + len(link)
+                    replacement = 'https' + link[4:]
+                    replacement = current_line[:start] +
+                        'https' + link[4:] + current_line[end:]


E113 unexpected indentation

Origin: PycodestyleBear (E113), Section: autopep8.

gitmate-bot · 2017-10-12T09:37:10Z

bears/general/HTTPSBear.py

+                    end = start + len(link)
+                    replacement = 'https' + link[4:]
+                    replacement = current_line[:start] +
+                        'https' + link[4:] + current_line[end:]


E113 unexpected indentation

Origin: PycodestyleBear (E113), Section: autopep8.

jayvdb · 2018-04-21T23:09:29Z

bears/general/HTTPSBear.py

+    HTTP_PREFIX = 'http'
+
+    def run(self, filename, file, dependency_results=dict(),
+            network_timeout: typed_dict(str, int, DEFAULT_TIMEOUT)=dict()):


style change requires spaces around =

stellargo · 2018-04-22T08:34:49Z

@jayvdb So basically this bear needs to use URLHeadBear to get a response for the new https link obtained from http. Problem is that when there is no such link it returns a ConnectTimeout Exception. This obviously does not have a status_code attribute. Hence i have used the try except block. But this is making testing extremely problematic because the custom_matcher first checks prerequisites and the LocalBearTestHelper immediately raises AssertionError. This was not the problem earlier when the URLBear hadn't been split into the two bears as then it would just return None for the attribute status_code. So either we could re change the URLHeadBear's get_head_response method to the way it was, or use the pragma no cover which I have added right now.
Other bears like InvalidLinkBear are not having this problem because they are just dependent on the URLHeadBear's result and don't want to make any more head response for status codes.

jayvdb

Im happy to let this pragma in. we can worry about that later.

A few style issues.

jayvdb · 2018-04-22T08:59:06Z

bears/general/HTTPSBear.py

+            network_timeout = {
+                urlparse(url).netloc if not url == '*' else '*': timeout
+                for url, timeout in network_timeout.items()}
+            httpsresponse = URLHeadBear.get_head_response(


snake_case (everywhere)

jayvdb · 2018-04-22T09:00:14Z

bears/general/HTTPSBear.py

+            current_line = file[line_number - 1]
+            start = current_line.find(link)
+            end = start + len(link)
+            replacement = current_line[:start] + 'https' + \


dont use \

jayvdb · 2018-04-22T09:00:24Z

bears/general/HTTPSBear.py

+
+            yield Result.from_values(
+                origin=self,
+                message=('https can be used instead of http'),


HTTPS bear can detect URL links which can be changed to https from http and changes them if the user wants. Closes coala#1900

jayvdb · 2018-04-22T09:27:08Z

ack bbfb116

jayvdb · 2018-04-22T11:17:05Z

@gitmate-bot ff

gitmate-bot · 2018-04-22T11:17:07Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2018-04-22T11:17:19Z

Automated fastforward with GitMate.io was successful! 🎉

gitmate-bot added process/pending review size/XS bear proposal difficulty/low status/STALE labels Oct 3, 2017

gitmate-bot assigned stellargo Oct 3, 2017

gitmate-bot reviewed Oct 3, 2017

View reviewed changes

co-robo added process/wip and removed process/pending review labels Oct 3, 2017

stellargo force-pushed the httpsbear branch from 7f6c1dc to a572a83 Compare October 3, 2017 10:01

gitmate-bot added process/pending review and removed status/STALE labels Oct 3, 2017

co-robo removed the process/pending review label Oct 3, 2017

Makman2 reviewed Oct 3, 2017

View reviewed changes

gitmate-bot added the status/STALE label Oct 11, 2017

stellargo force-pushed the httpsbear branch from a572a83 to 7e2366c Compare October 12, 2017 09:33

gitmate-bot added process/pending review status/STALE and removed status/STALE labels Oct 12, 2017

gitmate-bot reviewed Oct 12, 2017

View reviewed changes

stellargo force-pushed the httpsbear branch from 7e2366c to cc5bb59 Compare October 12, 2017 09:36

gitmate-bot added status/STALE and removed status/STALE labels Oct 12, 2017

gitmate-bot reviewed Oct 12, 2017

View reviewed changes

stellargo force-pushed the httpsbear branch from cc5bb59 to d25a6d6 Compare October 12, 2017 09:46

gitmate-bot added status/STALE and removed status/STALE labels Oct 12, 2017

stellargo force-pushed the httpsbear branch from d25a6d6 to 02a6c36 Compare October 12, 2017 09:51

gitmate-bot added the process/pending review label Apr 21, 2018

stellargo force-pushed the httpsbear branch 3 times, most recently from aed4265 to 2663270 Compare April 21, 2018 19:36

jayvdb requested changes Apr 21, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Apr 21, 2018

stellargo force-pushed the httpsbear branch from 2663270 to 80dfc1b Compare April 22, 2018 08:26

gitmate-bot added process/pending review and removed process/wip labels Apr 22, 2018

jayvdb requested changes Apr 22, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Apr 22, 2018

stellargo force-pushed the httpsbear branch from 80dfc1b to f5bacdb Compare April 22, 2018 09:04

gitmate-bot added process/pending review and removed process/wip labels Apr 22, 2018

jayvdb added process/wip and removed process/pending review status/STALE labels Apr 22, 2018

HTTPSBear.py: New Bear Added

bbfb116

HTTPS bear can detect URL links which can be changed to https from http and changes them if the user wants. Closes coala#1900

stellargo force-pushed the httpsbear branch from f5bacdb to bbfb116 Compare April 22, 2018 09:18

gitmate-bot added process/pending review and removed process/wip labels Apr 22, 2018

jayvdb approved these changes Apr 22, 2018

View reviewed changes

gitmate-bot merged commit bbfb116 into coala:master Apr 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTTPSBear.py: New Bear Added #2063

HTTPSBear.py: New Bear Added #2063

stellargo commented Oct 3, 2017 •

edited

Loading

gitmate-bot Oct 3, 2017

gitmate-bot Oct 3, 2017

Makman2 Oct 3, 2017

stellargo Oct 3, 2017 •

edited

Loading

Makman2 Oct 3, 2017

Makman2 Oct 3, 2017

Makman2 Oct 3, 2017

Makman2 Oct 3, 2017

Makman2 Oct 3, 2017

Makman2 Oct 3, 2017

Makman2 Oct 3, 2017

gitmate-bot Oct 12, 2017

gitmate-bot Oct 12, 2017

jayvdb Apr 21, 2018

stellargo commented Apr 22, 2018 •

edited

Loading

jayvdb left a comment

jayvdb Apr 22, 2018

jayvdb Apr 22, 2018

jayvdb Apr 22, 2018

jayvdb commented Apr 22, 2018

jayvdb commented Apr 22, 2018

gitmate-bot commented Apr 22, 2018

gitmate-bot commented Apr 22, 2018

HTTPSBear.py: New Bear Added #2063

HTTPSBear.py: New Bear Added #2063

Conversation

stellargo commented Oct 3, 2017 • edited Loading

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stellargo Oct 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stellargo commented Apr 22, 2018 • edited Loading

jayvdb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Apr 22, 2018

jayvdb commented Apr 22, 2018

gitmate-bot commented Apr 22, 2018

gitmate-bot commented Apr 22, 2018

stellargo commented Oct 3, 2017 •

edited

Loading

stellargo Oct 3, 2017 •

edited

Loading

stellargo commented Apr 22, 2018 •

edited

Loading