activity/scraper: Fix reqs and indexing issues #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ack e683dc8 |
gitmate-bot
added
process/approved
process/pending review
and removed
process/pending review
process/approved
labels
nalinbhardwaj
changed the title
jayvdb
reviewed
Dec 9, 2017
| @@ -2,3 +2,4 @@ django<2.0 | |||
| django-distill | |||
| IGitt | |||
| requests | |||
| python-dateutil | |||
There was a problem hiding this comment.
What do you mean? The repo requirements.txt doesn't contain it.
Edit: This is the same PR, I have just modified it to include the other changes.
hemangsk
reviewed
Dec 9, 2017
activity/scraper.py
Outdated
| @@ -108,20 +108,23 @@ def get_data(self): | |||
| mon = self.__diff_month(dt) | |||
| if mon < self.CONSTANTS['month_count']: | |||
| mon = self.CONSTANTS['month_count'] - mon | |||
| mon = self.CONSTANTS['month_count'] - mon - 1 | |||
There was a problem hiding this comment.
Inplace of L110 111
mon = 0.5 * self.CONSTANTS['month_count'] - 1
should do the job ?
There was a problem hiding this comment.
Damn, sourcetree messed up the staging I think. Fixing.(the -1 is in the same line)
Fixes previous commit by adding dateutil to requirements.txt and fixing indexing errors for weeks and months. Related to #27
|
ack 1a8289e |
jayvdb
approved these changes
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes previous commit.
Related to #27