Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coafile.rst: Add aspects section #462

Merged
merged 1 commit into from Aug 29, 2017
Merged

Conversation

@adhikasp
Copy link
Member

@adhikasp adhikasp commented Aug 24, 2017

Relates to coala/coala#4665

@jayvdb
Copy link
Member

@jayvdb jayvdb commented Aug 24, 2017

CI failing

@adhikasp adhikasp force-pushed the adhikasp:adhikasp/aspect-doc branch from 90506bd to 30b1041 Aug 24, 2017
@jayvdb
Copy link
Member

@jayvdb jayvdb commented Aug 26, 2017

Is this example real?
I believe it wont work, as no bear understands this yet.
So, this documentation needs to be merged only if a bear is enhanced.

@adhikasp
Copy link
Member Author

@adhikasp adhikasp commented Aug 26, 2017

I think I will change it to be more abstract (showing dummy config/non real aspect like above in this file). After a bear got aspectized, I will add the Tutorial.rst for the working, real example

@adhikasp adhikasp force-pushed the adhikasp:adhikasp/aspect-doc branch from 30b1041 to fa0f765 Aug 28, 2017
@adhikasp adhikasp force-pushed the adhikasp:adhikasp/aspect-doc branch from fa0f765 to 8f4f4af Aug 29, 2017
files = **
aspects = aspectname1, AspectName2 # case-insensitive
# defining an aspect's taste
aspectname1.aspect_taste = 80

This comment has been minimized.

@jayvdb

jayvdb Aug 29, 2017
Member

. should be :

Relates to coala/coala#4665
@adhikasp adhikasp force-pushed the adhikasp:adhikasp/aspect-doc branch from 8f4f4af to 682c13d Aug 29, 2017
@jayvdb
jayvdb approved these changes Aug 29, 2017
@jayvdb
Copy link
Member

@jayvdb jayvdb commented Aug 29, 2017

ack 682c13d

@jayvdb
Copy link
Member

@jayvdb jayvdb commented Aug 29, 2017

@rultor merge

@rultor
Copy link

@rultor rultor commented Aug 29, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 682c13d into coala:master Aug 29, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor
Copy link

@rultor rultor commented Aug 29, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants