Skip to content

Conversation

yunusstalha
Copy link
Contributor

I implemented a safeguard in the calculation method to ensure that PCA and k-means clustering calculations are only performed if images have been successfully read into the system. I added the ability to export image embeddings to a specified directory as a ".npy" file through the export_embeddings method.

@cobanov
Copy link
Owner

cobanov commented Mar 11, 2024

Thank you for your support, I wonder if you think raising an error message instead of a print would be a better option?

 if not value:
        raise ValueError("Value must be a positive integer")

@yunusstalha
Copy link
Contributor Author

Thank you for your support; I wonder if you think raising an error message instead of a print would be a better option?

 if not value:
        raise ValueError("Value must be a positive integer")

I've switched to raising errors instead of just warnings to clearly indicate that certain actions are not permitted, ensuring users are immediately aware of the issue.

@cobanov cobanov closed this Mar 12, 2024
@cobanov cobanov reopened this Mar 12, 2024
@cobanov cobanov merged commit 6af76fb into cobanov:main Mar 12, 2024
@cobanov
Copy link
Owner

cobanov commented Mar 12, 2024

Perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants