Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust map types #58

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Adjust map types #58

merged 2 commits into from
Aug 16, 2024

Conversation

SchoolGuy
Copy link
Member

See individual commits

This is allowed since on the Python side we only allow single-level dictionaries that have str values
@SchoolGuy SchoolGuy added this to the 0.5.0 milestone Aug 16, 2024
Copy link

codacy-production bot commented Aug 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.27% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0200f10) 2111 989 46.85%
Head commit (9773df3) 2173 (+62) 1024 (+35) 47.12% (+0.27%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#58) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@SchoolGuy
Copy link
Member Author

CI is green, the main reviewer is still on vacation, merging with admin privileges as such.

@SchoolGuy SchoolGuy merged commit caa2583 into main Aug 16, 2024
13 checks passed
@SchoolGuy SchoolGuy deleted the feature/adjust-map-types branch August 16, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant