ReactNativeStarter #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alacret
requested changes
Apr 19, 2021
alacret
requested changes
Apr 29, 2021
added 2 commits
April 29, 2021 09:42
alacret
requested changes
Apr 29, 2021
app/auth/auth.tsx
Outdated
| .authorize({ | ||
| scope: 'openid profile email', | ||
| }) | ||
| .then((credentials) => { |
There was a problem hiding this comment.
no, then / catch logic in the Views, we need to handle this with events and subscriptions
alacret
requested changes
May 3, 2021
app/auth/auth.tsx
Outdated
| }, | ||
| }); | ||
|
|
||
| export const Auth = ({ navigation }): ReactElement => { |
There was a problem hiding this comment.
This file name should be CamelCase
app/auth/auth.tsx
Outdated
| const loggedIn = useEvent(LoginEvent); | ||
|
|
||
| const onLogin = (): void => { | ||
| auth0.webAuth |
There was a problem hiding this comment.
This news to be put in an action file
app/dashboard/Dashboard.tsx
Outdated
| const data = useEvent(TokensEvent).idToken; | ||
|
|
||
| const onLogout = (): void => { | ||
| auth0.webAuth |
There was a problem hiding this comment.
This should be in an action file.
Also, the file structure is not correct
alacret
requested changes
May 4, 2021
added 2 commits
May 4, 2021 13:54
alacret
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New application starter for react-native