Skip to content

Commit

Permalink
tools: Build cockpit-packagekit on ubuntu-1604
Browse files Browse the repository at this point in the history
Now that PackageKit stopped crashing in Ubuntu 16.04
(https://launchpad.net/bugs/1689820), enable the package there. However,
that version is not able to read changelogs from apt yet, so still skip
the two corresponding tests.

Fixes #7465
  • Loading branch information
martinpitt committed Sep 6, 2017
1 parent 38ddac9 commit d387033
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
3 changes: 2 additions & 1 deletion test/verify/check-packagekit
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ done
"""

@skipImage("Image uses OSTree", "continuous-atomic", "fedora-atomic", "rhel-atomic")
@skipImage("PackageKit crashes, https://launchpad.net/bugs/1689820", "ubuntu-1604")
class TestUpdates(PackageCase):
def setUp(self):
PackageCase.setUp(self)
Expand Down Expand Up @@ -149,6 +148,7 @@ class TestUpdates(PackageCase):
# new versions are now installed
m.execute("test -f /stamp-vanilla-1.0-2 && test -f /stamp-chocolate-2.0-2")

@skipImage("Ubuntu 16.04 PackageKit does not support changelogs", "ubuntu-1604")
def testInfoSecurity(self):
b = self.browser
m = self.machine
Expand Down Expand Up @@ -307,6 +307,7 @@ class TestUpdates(PackageCase):

self.allow_restart_journal_messages()

@skipImage("Ubuntu 16.04 PackageKit does not support changelogs", "ubuntu-1604")
def testInfoTruncation(self):
b = self.browser
m = self.machine
Expand Down
6 changes: 0 additions & 6 deletions tools/debian/rules
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ ifneq ($(shell dpkg -s libpcp3-dev >/dev/null 2>&1 && echo yes),yes)
CONFIG_OPTIONS = --disable-pcp
endif

# PackageKit crashes on update information on Ubuntu 16.04, which makes
# "Software Updates" useless (LP: #1689820)
ifneq ($(shell grep xenial /etc/os-release),)
export DH_OPTIONS += -Ncockpit-packagekit
endif

%:
dh $@ --with=systemd,autoreconf

Expand Down

0 comments on commit d387033

Please sign in to comment.