Test: additional, optional wait for vm to be reachable via ssh #1988
Conversation
|
The code above the stuff you added waits for the VM To report that the network is initialized, and times out if it doesn't. Why would waiting further solve the issue? |
|
The code waits until everything is set up properly inside the vm. On my machines (nested virtualization) sometimes the guest isn't yet reachable from the host via ssh when the vm declares itself ready. I will investigate this further - waiting for an ssh connection to become available as suggested by @jscotka might be the cleaner solution here instead of a hardcoded wait. |
|
The existing wait code waits for user login in the vm to become available. Sometimes, especially under load, network init can take longer. |
dperpeet
changed the title
|
replaced telnet call with python socket |
| @@ -665,6 +665,22 @@ def _parse_cockpit_canary(self, canary, output): | |||
| return None | |||
| return output[beg:end].strip() | |||
|
|
|||
| def wait_ssh(self): | |||
There was a problem hiding this comment.
Technically this should go on 'Machine' instead of 'QemuMachine'
This time is sometimes necessary for network init Closes cockpit-project#1988
This time is sometimes necessary for network init