bots: Minimize races filing issues for bots #7825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to file or check for these issues on every iteration through the .tasks script. Lets start doing it one in every 10 times.
martinpitt
requested changes
Oct 6, 2017
| bots/image-trigger | ||
| bots/npm-trigger | ||
| bots/naughty-trigger | ||
| if [ $chance -gt 9 ]; then |
There was a problem hiding this comment.
You need -ge here, otherwise this will never be true.
There was a problem hiding this comment.
Are you sure? I think shuf -i 1-10 produces the number 10.
There was a problem hiding this comment.
Sorry, indeed it does. (That's unlike random(10) in most other places).
| bots/tests-scan | ||
|
|
||
| # When run automated, randomize to minimize stampeding hurd |
There was a problem hiding this comment.
"herd" or "hurt"? (the former, I suppose)
martinpitt
approved these changes
Oct 6, 2017
| bots/image-trigger | ||
| bots/npm-trigger | ||
| bots/naughty-trigger | ||
| if [ $chance -gt 9 ]; then |
There was a problem hiding this comment.
Sorry, indeed it does. (That's unlike random(10) in most other places).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to file or check for these issues on every iteration
through the .tasks script. Lets start doing it one in every 10 times.