-
Notifications
You must be signed in to change notification settings - Fork 3.9k
/
Copy pathserver.go
853 lines (797 loc) · 27.5 KB
/
server.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
// Copyright 2022 The Cockroach Authors.
//
// Use of this software is governed by the Business Source License
// included in the file licenses/BSL.txt.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0, included in the file
// licenses/APL.txt.
package loqrecovery
import (
"context"
"fmt"
"io"
"sync/atomic"
"time"
"github.com/cockroachdb/cockroach/pkg/base"
"github.com/cockroachdb/cockroach/pkg/gossip"
"github.com/cockroachdb/cockroach/pkg/keys"
"github.com/cockroachdb/cockroach/pkg/kv"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/liveness"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/liveness/livenesspb"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/loqrecovery/loqrecoverypb"
"github.com/cockroachdb/cockroach/pkg/roachpb"
"github.com/cockroachdb/cockroach/pkg/rpc"
"github.com/cockroachdb/cockroach/pkg/server/serverpb"
"github.com/cockroachdb/cockroach/pkg/settings/cluster"
"github.com/cockroachdb/cockroach/pkg/util/grpcutil"
"github.com/cockroachdb/cockroach/pkg/util/iterutil"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/cockroach/pkg/util/protoutil"
"github.com/cockroachdb/cockroach/pkg/util/retry"
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
"github.com/cockroachdb/errors"
"github.com/cockroachdb/redact"
"golang.org/x/sync/errgroup"
"google.golang.org/grpc"
)
const rangeMetadataScanChunkSize = 100
const retrieveNodeStatusTimeout = 30 * time.Second
const retrieveKeyspaceHealthTimeout = time.Minute
var fanOutConnectionRetryOptions = retry.Options{
MaxRetries: 3,
InitialBackoff: time.Second,
Multiplier: 1,
}
var errMarkRetry = errors.New("retryable")
func IsRetryableError(err error) bool {
return errors.Is(err, errMarkRetry)
}
type visitNodeAdminFn func(nodeID roachpb.NodeID, client serverpb.AdminClient) error
type visitNodesAdminFn func(ctx context.Context, retryOpts retry.Options, maxConcurrency int32,
nodeFilter func(nodeID roachpb.NodeID) bool,
visitor visitNodeAdminFn,
) error
type visitNodeStatusFn func(ctx context.Context, nodeID roachpb.NodeID, retryOpts retry.Options,
visitor func(client serverpb.StatusClient) error,
) error
type Server struct {
nodeIDContainer *base.NodeIDContainer
clusterIDContainer *base.ClusterIDContainer
settings *cluster.Settings
stores *kvserver.Stores
visitAdminNodes visitNodesAdminFn
visitStatusNode visitNodeStatusFn
planStore PlanStore
decommissionFn func(context.Context, roachpb.NodeID) error
metadataQueryTimeout time.Duration
forwardReplicaFilter func(*serverpb.RecoveryCollectLocalReplicaInfoResponse) error
}
func NewServer(
nodeIDContainer *base.NodeIDContainer,
settings *cluster.Settings,
stores *kvserver.Stores,
planStore PlanStore,
g *gossip.Gossip,
loc roachpb.Locality,
rpcCtx *rpc.Context,
knobs base.ModuleTestingKnobs,
decommission func(context.Context, roachpb.NodeID) error,
) *Server {
// Server side timeouts are necessary in recovery collector since we do best
// effort operations where cluster info collection as an operation succeeds
// even if some parts of it time out.
metadataQueryTimeout := 1 * time.Minute
var forwardReplicaFilter func(*serverpb.RecoveryCollectLocalReplicaInfoResponse) error
if rk, ok := knobs.(*TestingKnobs); ok {
if rk.MetadataScanTimeout > 0 {
metadataQueryTimeout = rk.MetadataScanTimeout
}
forwardReplicaFilter = rk.ForwardReplicaFilter
}
return &Server{
nodeIDContainer: nodeIDContainer,
clusterIDContainer: rpcCtx.StorageClusterID,
settings: settings,
stores: stores,
visitAdminNodes: makeVisitAvailableNodesInParallel(g, loc, rpcCtx),
visitStatusNode: makeVisitNode(g, loc, rpcCtx),
planStore: planStore,
decommissionFn: decommission,
metadataQueryTimeout: metadataQueryTimeout,
forwardReplicaFilter: forwardReplicaFilter,
}
}
func (s Server) ServeLocalReplicas(
ctx context.Context,
_ *serverpb.RecoveryCollectLocalReplicaInfoRequest,
stream serverpb.Admin_RecoveryCollectLocalReplicaInfoServer,
) error {
v := s.settings.Version.ActiveVersion(ctx)
var stores []*kvserver.Store
if err := s.stores.VisitStores(func(s *kvserver.Store) error {
stores = append(stores, s)
return nil
}); err != nil {
return err
}
syncStream := makeThreadSafeStream[*serverpb.RecoveryCollectLocalReplicaInfoResponse](stream)
stream = nil // prevent misuse
var g errgroup.Group
for _, s := range stores {
s := s // copy for closure
g.Go(func() error {
reader := s.TODOEngine().NewSnapshot()
defer reader.Close()
return visitStoreReplicas(ctx, reader, s.StoreID(), s.NodeID(), v,
func(info loqrecoverypb.ReplicaInfo) error {
return syncStream.Send(&serverpb.RecoveryCollectLocalReplicaInfoResponse{ReplicaInfo: &info})
})
})
}
return g.Wait()
}
func (s Server) ServeClusterReplicas(
ctx context.Context,
req *serverpb.RecoveryCollectReplicaInfoRequest,
outStream serverpb.Admin_RecoveryCollectReplicaInfoServer,
kvDB *kv.DB,
) (err error) {
var descriptors, nodes, replicas atomic.Int64
defer func() {
if err == nil {
log.Infof(ctx, "streamed info: range descriptors %d, nodes %d, replica infos %d",
descriptors.Load(), nodes.Load(), replicas.Load())
}
}()
v := s.settings.Version.ActiveVersion(ctx)
if err = outStream.Send(&serverpb.RecoveryCollectReplicaInfoResponse{
Info: &serverpb.RecoveryCollectReplicaInfoResponse_Metadata{
Metadata: &loqrecoverypb.ClusterMetadata{
ClusterID: s.clusterIDContainer.String(),
Version: v.Version,
},
},
}); err != nil {
return err
}
err = timeutil.RunWithTimeout(ctx, "scan range descriptors", s.metadataQueryTimeout,
func(txnCtx context.Context) error {
txn := kvDB.NewTxn(txnCtx, "scan-range-descriptors")
if err := txn.SetFixedTimestamp(txnCtx, kvDB.Clock().Now()); err != nil {
return err
}
defer func() { _ = txn.Rollback(txnCtx) }()
log.Infof(txnCtx, "serving recovery range descriptors for all ranges")
return txn.Iterate(txnCtx, keys.Meta2Prefix, keys.MetaMax, rangeMetadataScanChunkSize,
func(kvs []kv.KeyValue) error {
for _, rangeDescKV := range kvs {
var rangeDesc roachpb.RangeDescriptor
if err := rangeDescKV.ValueProto(&rangeDesc); err != nil {
return err
}
if err := outStream.Send(&serverpb.RecoveryCollectReplicaInfoResponse{
Info: &serverpb.RecoveryCollectReplicaInfoResponse_RangeDescriptor{
RangeDescriptor: &rangeDesc,
},
}); err != nil {
return err
}
descriptors.Add(1)
}
return nil
})
})
if err != nil {
// Error means either kv transaction error or stream send error.
// We don't care about transaction errors because cluster is might be in a
// crippled state, but we don't want to keep continue if client stream is
// closed.
if outStream.Context().Err() != nil {
return err
}
log.Infof(ctx, "failed to iterate all descriptors: %s", err)
}
// Stream local replica info from all nodes wrapping them in response stream.
syncOutStream := makeThreadSafeStream[*serverpb.RecoveryCollectReplicaInfoResponse](outStream)
return s.visitAdminNodes(
ctx,
fanOutConnectionRetryOptions,
req.MaxConcurrency,
allNodes,
serveClusterReplicasParallelFn(ctx, syncOutStream, s.forwardReplicaFilter, &replicas, &nodes))
}
func serveClusterReplicasParallelFn(
ctx context.Context,
outStream *threadSafeStream[*serverpb.RecoveryCollectReplicaInfoResponse],
forwardReplicaFilter func(*serverpb.RecoveryCollectLocalReplicaInfoResponse) error,
replicas, nodes *atomic.Int64,
) visitNodeAdminFn {
return func(nodeID roachpb.NodeID, client serverpb.AdminClient) error {
log.Infof(ctx, "trying to get info from node n%d", nodeID)
var nodeReplicas int64
inStream, err := client.RecoveryCollectLocalReplicaInfo(ctx,
&serverpb.RecoveryCollectLocalReplicaInfoRequest{})
if err != nil {
return errors.Mark(errors.Wrapf(err,
"failed retrieving replicas from node n%d during fan-out", nodeID), errMarkRetry)
}
for {
r, err := inStream.Recv()
if err == io.EOF {
break
}
if forwardReplicaFilter != nil {
err = forwardReplicaFilter(r)
}
if err != nil {
// Some replicas were already sent back, need to notify client of stream
// restart.
if err := outStream.Send(&serverpb.RecoveryCollectReplicaInfoResponse{
Info: &serverpb.RecoveryCollectReplicaInfoResponse_NodeStreamRestarted{
NodeStreamRestarted: &serverpb.RecoveryCollectReplicaRestartNodeStream{
NodeID: nodeID,
},
},
}); err != nil {
return err
}
return errors.Mark(errors.Wrapf(err,
"failed retrieving replicas from node n%d during fan-out",
nodeID), errMarkRetry)
}
if err := outStream.Send(&serverpb.RecoveryCollectReplicaInfoResponse{
Info: &serverpb.RecoveryCollectReplicaInfoResponse_ReplicaInfo{
ReplicaInfo: r.ReplicaInfo,
},
}); err != nil {
return err
}
nodeReplicas++
}
replicas.Add(nodeReplicas)
nodes.Add(1)
return nil
}
}
func (s Server) StagePlan(
ctx context.Context, req *serverpb.RecoveryStagePlanRequest,
) (*serverpb.RecoveryStagePlanResponse, error) {
if !req.ForcePlan && req.Plan == nil {
return nil, errors.New("stage plan request can't be used with empty plan without force flag")
}
if p := req.Plan; p != nil {
clusterID := s.clusterIDContainer.Get().String()
if p.ClusterID != clusterID {
return nil, errors.Newf("attempting to stage plan from cluster %s on cluster %s",
p.ClusterID, clusterID)
}
version := s.settings.Version.ActiveVersion(ctx)
if err := checkPlanVersionMatches(p.Version, version.Version, req.ForceLocalInternalVersion); err != nil {
return nil, errors.Wrap(err, "incompatible plan")
}
// It is safe to always update internal to reflect active version since it
// is allowed by the check above or is not needed.
p.Version.Internal = version.Internal
}
localNodeID := s.nodeIDContainer.Get()
// Create a plan copy with all empty fields to shortcut all plan nil checks
// below to avoid unnecessary nil checks.
var plan loqrecoverypb.ReplicaUpdatePlan
if req.Plan != nil {
plan = *req.Plan
}
if req.AllNodes {
// Scan cluster for conflicting recovery plans and for stray nodes that are
// planned for forced decommission, but rejoined cluster.
foundNodes := makeThreadSafeMap[roachpb.NodeID, bool]()
err := s.visitAdminNodes(
ctx,
fanOutConnectionRetryOptions,
req.MaxConcurrency,
allNodes,
stagePlanRecoveryNodeStatusParallelFn(ctx, req, plan, foundNodes))
if err != nil {
return nil, err
}
// Check that no nodes that must be decommissioned are present.
for _, dID := range plan.DecommissionedNodeIDs {
if foundNodes.Get(dID) {
return nil, errors.Newf("node n%d was planned for decommission, but is present in cluster", dID)
}
}
// Check out that all nodes that should save plan are present.
for _, u := range plan.Updates {
if !foundNodes.Get(u.NodeID()) {
return nil, errors.Newf("node n%d has planned changed but is unreachable in the cluster", u.NodeID())
}
}
for _, n := range plan.StaleLeaseholderNodeIDs {
if !foundNodes.Get(n) {
return nil, errors.Newf("node n%d has planned restart but is unreachable in the cluster", n)
}
}
// Distribute plan - this should not use fan out to available, but use
// list from previous step.
var nodeErrors threadSafeSlice[string]
err = s.visitAdminNodes(
ctx,
fanOutConnectionRetryOptions,
req.MaxConcurrency,
onlyListed(foundNodes.Clone()),
stagePlanRecoveryStagePlanParallelFn(ctx, req, foundNodes, &nodeErrors))
if err != nil {
nodeErrors.Append(
errors.Wrapf(err, "failed to perform fan-out to cluster nodes from n%d", localNodeID).Error())
}
if foundNodes.Len() > 0 {
// We didn't talk to some of originally found nodes. Need to report
// disappeared nodes as we don't know what is happening with the cluster.
for n := range foundNodes.Clone() {
nodeErrors.Append(fmt.Sprintf("node n%d disappeared while performing plan staging operation", n))
}
}
return &serverpb.RecoveryStagePlanResponse{Errors: nodeErrors.Clone()}, nil
}
log.Infof(ctx, "attempting to stage loss of quorum recovery plan")
responseFromError := func(err error) (*serverpb.RecoveryStagePlanResponse, error) {
return &serverpb.RecoveryStagePlanResponse{
Errors: []string{
errors.Wrapf(err, "failed to stage plan on node n%d", localNodeID).Error(),
},
}, nil
}
existingPlan, exists, err := s.planStore.LoadPlan()
if err != nil {
return responseFromError(err)
}
if exists && !existingPlan.PlanID.Equal(plan.PlanID) && !req.ForcePlan {
return responseFromError(errors.Newf("conflicting plan %s is already staged", existingPlan.PlanID))
}
for _, node := range plan.DecommissionedNodeIDs {
if err := s.decommissionFn(ctx, node); err != nil {
return responseFromError(err)
}
}
if req.ForcePlan {
if err := s.planStore.RemovePlan(); err != nil {
return responseFromError(err)
}
}
needsUpdate := false
for _, r := range plan.Updates {
if r.NodeID() == localNodeID {
needsUpdate = true
break
}
}
if !needsUpdate {
for _, n := range plan.StaleLeaseholderNodeIDs {
if n == localNodeID {
needsUpdate = true
break
}
}
}
if needsUpdate {
if err := s.planStore.SavePlan(plan); err != nil {
return responseFromError(err)
}
}
return &serverpb.RecoveryStagePlanResponse{}, nil
}
func stagePlanRecoveryNodeStatusParallelFn(
ctx context.Context,
req *serverpb.RecoveryStagePlanRequest,
plan loqrecoverypb.ReplicaUpdatePlan,
foundNodes *threadSafeMap[roachpb.NodeID, bool],
) visitNodeAdminFn {
return func(nodeID roachpb.NodeID, client serverpb.AdminClient) error {
res, err := client.RecoveryNodeStatus(ctx, &serverpb.RecoveryNodeStatusRequest{})
if err != nil {
return errors.Mark(err, errMarkRetry)
}
// If operation fails here, we don't want to find all remaining
// violating nodes because cli must ensure that cluster is safe for
// staging.
if !req.ForcePlan && res.Status.PendingPlanID != nil && !res.Status.PendingPlanID.Equal(plan.PlanID) {
return errors.Newf("plan %s is already staged on node n%d", res.Status.PendingPlanID, nodeID)
}
foundNodes.Set(nodeID, true)
return nil
}
}
func stagePlanRecoveryStagePlanParallelFn(
ctx context.Context,
req *serverpb.RecoveryStagePlanRequest,
foundNodes *threadSafeMap[roachpb.NodeID, bool],
nodeErrors *threadSafeSlice[string],
) visitNodeAdminFn {
return func(nodeID roachpb.NodeID, client serverpb.AdminClient) error {
foundNodes.Delete(nodeID)
res, err := client.RecoveryStagePlan(ctx, &serverpb.RecoveryStagePlanRequest{
Plan: req.Plan,
AllNodes: false,
ForcePlan: req.ForcePlan,
ForceLocalInternalVersion: req.ForceLocalInternalVersion,
MaxConcurrency: req.MaxConcurrency,
})
if err != nil {
nodeErrors.Append(
errors.Wrapf(err, "failed staging the plan on node n%d", nodeID).Error())
return nil
}
nodeErrors.Append(res.Errors...)
return nil
}
}
func (s Server) NodeStatus(
ctx context.Context, _ *serverpb.RecoveryNodeStatusRequest,
) (*serverpb.RecoveryNodeStatusResponse, error) {
status := loqrecoverypb.NodeRecoveryStatus{
NodeID: s.nodeIDContainer.Get(),
}
plan, exists, err := s.planStore.LoadPlan()
if err != nil {
return nil, err
}
if exists {
status.PendingPlanID = &plan.PlanID
}
err = s.stores.VisitStores(func(s *kvserver.Store) error {
r, ok, err := readNodeRecoveryStatusInfo(ctx, s.TODOEngine())
if err != nil {
return err
}
if ok {
status.AppliedPlanID = &r.AppliedPlanID
status.ApplyTimestamp = &r.ApplyTimestamp
status.Error = r.Error
return iterutil.StopIteration()
}
return nil
})
if err = iterutil.Map(err); err != nil {
log.Errorf(ctx, "failed to read loss of quorum recovery application status %s", err)
return nil, err
}
return &serverpb.RecoveryNodeStatusResponse{
Status: status,
}, nil
}
func (s Server) Verify(
ctx context.Context, req *serverpb.RecoveryVerifyRequest, nl *liveness.NodeLiveness, db *kv.DB,
) (*serverpb.RecoveryVerifyResponse, error) {
var nss threadSafeSlice[loqrecoverypb.NodeRecoveryStatus]
err := s.visitAdminNodes(
ctx,
fanOutConnectionRetryOptions,
req.MaxConcurrency,
notListed(req.DecommissionedNodeIDs),
verifyRecoveryNodeStatusParallelFn(ctx, &nss))
if err != nil {
return nil, err
}
decomNodes := make(map[roachpb.NodeID]bool)
decomStatus := make(map[roachpb.NodeID]livenesspb.MembershipStatus, len(req.DecommissionedNodeIDs))
for _, plannedID := range req.DecommissionedNodeIDs {
decomNodes[plannedID] = true
decomStatus[plannedID] = nl.GetNodeVitalityFromCache(plannedID).MembershipStatus()
}
isNodeLive := func(rd roachpb.ReplicaDescriptor) bool {
// Preemptively remove dead nodes as they would return Forbidden error if
// liveness is not stale enough.
if decomNodes[rd.NodeID] {
return false
}
return nl.GetNodeVitalityFromCache(rd.NodeID).IsLive(livenesspb.LossOfQuorum)
}
getRangeInfo := func(
ctx context.Context, rID roachpb.RangeID, nID roachpb.NodeID,
) (serverpb.RangeInfo, error) {
var info serverpb.RangeInfo
err := s.visitStatusNode(ctx, nID, fanOutConnectionRetryOptions,
func(c serverpb.StatusClient) error {
resp, err := c.Range(ctx, &serverpb.RangeRequest{RangeId: int64(rID)})
if err != nil {
return err
}
res := resp.ResponsesByNodeID[nID]
if len(res.Infos) > 0 {
info = res.Infos[0]
return nil
}
return errors.Newf("range r%d not found on node n%d", rID, nID)
})
if err != nil {
return serverpb.RangeInfo{}, err
}
return info, nil
}
// Note that rangeCheckErr is a partial error, so we may have subset of ranges
// and an error, both of them will go to response.
unavailable, rangeCheckErr := func() ([]loqrecoverypb.RangeRecoveryStatus, error) {
var unavailable []loqrecoverypb.RangeRecoveryStatus
if req.MaxReportedRanges == 0 {
return nil, nil
}
err := timeutil.RunWithTimeout(ctx, "retrieve ranges health", retrieveKeyspaceHealthTimeout,
func(ctx context.Context) error {
start := keys.Meta2Prefix
for {
kvs, err := db.Scan(ctx, start, keys.MetaMax, rangeMetadataScanChunkSize)
if err != nil {
return err
}
if len(kvs) == 0 {
break
}
var endKey roachpb.Key
for _, rangeDescKV := range kvs {
endKey = rangeDescKV.Key
var d roachpb.RangeDescriptor
if err := rangeDescKV.ValueProto(&d); err != nil {
continue
}
h := checkRangeHealth(ctx, d, isNodeLive, getRangeInfo)
if h != loqrecoverypb.RangeHealth_HEALTHY {
if len(unavailable) >= int(req.MaxReportedRanges) {
return errors.Newf("found more failed ranges than limit %d",
req.MaxReportedRanges)
}
unavailable = append(unavailable, loqrecoverypb.RangeRecoveryStatus{
RangeID: d.RangeID,
Span: roachpb.Span{
Key: d.StartKey.AsRawKey(),
EndKey: d.EndKey.AsRawKey(),
},
Health: h,
})
}
}
start = endKey.Next()
}
return nil
})
// Note: we are returning partial results and an error in case we time out
// or hit unavailability or scan limit
return unavailable, err
}()
rangeHealth := serverpb.RecoveryVerifyResponse_UnavailableRanges{
Ranges: unavailable,
}
if rangeCheckErr != nil {
rangeHealth.Error = rangeCheckErr.Error()
}
return &serverpb.RecoveryVerifyResponse{
Statuses: nss.Clone(),
DecommissionedNodeStatuses: decomStatus,
UnavailableRanges: rangeHealth,
}, nil
}
func verifyRecoveryNodeStatusParallelFn(
ctx context.Context, nss *threadSafeSlice[loqrecoverypb.NodeRecoveryStatus],
) visitNodeAdminFn {
return func(nodeID roachpb.NodeID, client serverpb.AdminClient) error {
return timeutil.RunWithTimeout(ctx, redact.Sprintf("retrieve status of n%d", nodeID),
retrieveNodeStatusTimeout,
func(ctx context.Context) error {
res, err := client.RecoveryNodeStatus(ctx, &serverpb.RecoveryNodeStatusRequest{})
if err != nil {
return errors.Mark(errors.Wrapf(err, "failed to retrieve status of n%d", nodeID),
errMarkRetry)
}
nss.Append(res.Status)
return nil
})
}
}
func checkRangeHealth(
ctx context.Context,
d roachpb.RangeDescriptor,
liveFunc func(rd roachpb.ReplicaDescriptor) bool,
rangeInfo func(ctx context.Context, id roachpb.RangeID, nID roachpb.NodeID) (serverpb.RangeInfo, error),
) loqrecoverypb.RangeHealth {
if d.Replicas().CanMakeProgress(liveFunc) {
return loqrecoverypb.RangeHealth_HEALTHY
}
stuckReplica := false
healthyReplica := false
for _, r := range d.Replicas().Descriptors() {
// Check if node is in deleted nodes first.
if liveFunc(r) {
info, err := rangeInfo(ctx, d.RangeID, r.NodeID)
if err != nil {
// We can't reach node which is reported as live, skip this replica
// for now and check if remaining nodes could serve the range.
continue
}
canMakeProgress := info.State.Desc.Replicas().CanMakeProgress(liveFunc)
healthyReplica = healthyReplica || canMakeProgress
stuckReplica = stuckReplica || !canMakeProgress
}
}
// If we have a leaseholder that can't make progress it could block all
// operations on the range. Upreplication of healthy replica will update
// meta and resolve the issue.
if stuckReplica && healthyReplica {
return loqrecoverypb.RangeHealth_WAITING_FOR_META
}
// If we have healthy replica and no stuck replicas then this replica
// will respond.
if healthyReplica && !stuckReplica {
return loqrecoverypb.RangeHealth_HEALTHY
}
return loqrecoverypb.RangeHealth_LOSS_OF_QUORUM
}
// makeVisitAvailableNodesInParallel creates a function to visit available
// remote nodes, in parallel.
//
// Returned function would dial all cluster nodes from gossip and executes
// visitor function with admin client after connection is established. Function
// will perform retries on dial operation as well on visitor execution.
//
// For former, grpcutil.IsConnectionUnavailable check on returned error will
// abort retry loop because that indicates that node is not available. The
// expectation here is that we don't know if nodes in gossip are available or
// not and we don't want to block on dead nodes indefinitely.
//
// For latter, errors marked with errMarkRetry marker are retried. It is up
// to the visitor to mark appropriate errors are retryable.
//
// Nodes may be visited in parallel, so the visitor function must be safe for
// concurrent use.
func makeVisitAvailableNodesInParallel(
g *gossip.Gossip, loc roachpb.Locality, rpcCtx *rpc.Context,
) visitNodesAdminFn {
return func(
ctx context.Context,
retryOpts retry.Options,
maxConcurrency int32,
nodeFilter func(nodeID roachpb.NodeID) bool,
visitor visitNodeAdminFn,
) error {
var nodes []roachpb.NodeDescriptor
if err := g.IterateInfos(gossip.KeyNodeDescPrefix, func(key string, i gossip.Info) error {
b, err := i.Value.GetBytes()
if err != nil {
return errors.Wrapf(err, "failed to get node gossip info for key %s", key)
}
var d roachpb.NodeDescriptor
if err := protoutil.Unmarshal(b, &d); err != nil {
return errors.Wrapf(err, "failed to unmarshal node gossip info for key %s", key)
}
// Don't use node descriptors with NodeID 0, because that's meant to
// indicate that the node has been removed from the cluster.
if d.NodeID != 0 && nodeFilter(d.NodeID) {
nodes = append(nodes, d)
}
return nil
}); err != nil {
return err
}
var g errgroup.Group
if maxConcurrency == 0 {
// "A value of 0 disables concurrency."
maxConcurrency = 1
}
g.SetLimit(int(maxConcurrency))
for _, node := range nodes {
node := node // copy for closure
g.Go(func() error {
return visitNodeWithRetry(ctx, loc, rpcCtx, retryOpts, visitor, node)
})
}
return g.Wait()
}
}
func visitNodeWithRetry(
ctx context.Context,
loc roachpb.Locality,
rpcCtx *rpc.Context,
retryOpts retry.Options,
visitor visitNodeAdminFn,
node roachpb.NodeDescriptor,
) error {
var err error
for r := retry.StartWithCtx(ctx, retryOpts); r.Next(); {
log.Infof(ctx, "visiting node n%d, attempt %d", node.NodeID, r.CurrentAttempt())
addr := node.AddressForLocality(loc)
var conn *grpc.ClientConn
// Note that we use ConnectNoBreaker here to avoid any race with probe
// running on current node and target node restarting. Errors from circuit
// breaker probes could confuse us and present node as unavailable.
conn, err = rpcCtx.GRPCDialNode(addr.String(), node.NodeID, rpc.DefaultClass).ConnectNoBreaker(ctx)
// Nodes would contain dead nodes that we don't need to visit. We can skip
// them and let caller handle incomplete info.
if err != nil {
if grpcutil.IsConnectionUnavailable(err) {
log.Infof(ctx, "rejecting node n%d because of suspected un-retryable error: %s",
node.NodeID, err)
return nil
}
// This was an initial heartbeat type error, we must retry as node seems
// live.
continue
}
client := serverpb.NewAdminClient(conn)
err = visitor(node.NodeID, client)
if err == nil {
return nil
}
log.Infof(ctx, "failed calling a visitor for node n%d: %s", node.NodeID, err)
if !IsRetryableError(err) {
return err
}
}
return err
}
// makeVisitNode creates a function to visit a remote node.
//
// Returned function would dial a node and executes visitor function with
// status client after connection is established. Function will perform
// retries on dial operation as well on visitor execution.
//
// For former, closed connection errors will abort retry loop because that
// indicates that node is not available. The expectation here is that we are
// trying to talk to available nodes and all other errors are transient.
//
// For latter, errors marked with errMarkRetry marker are retried. It is up
// to the visitor to mark appropriate errors are retryable.
func makeVisitNode(g *gossip.Gossip, loc roachpb.Locality, rpcCtx *rpc.Context) visitNodeStatusFn {
return func(ctx context.Context, nodeID roachpb.NodeID, retryOpts retry.Options,
visitor func(client serverpb.StatusClient) error,
) error {
node, err := g.GetNodeDescriptor(nodeID)
if err != nil {
return err
}
for r := retry.StartWithCtx(ctx, retryOpts); r.Next(); {
log.Infof(ctx, "visiting node n%d, attempt %d", node.NodeID, r.CurrentAttempt())
addr := node.AddressForLocality(loc)
var conn *grpc.ClientConn
// Note that we use ConnectNoBreaker here to avoid any race with probe
// running on current node and target node restarting. Errors from circuit
// breaker probes could confuse us and present node as unavailable.
conn, err = rpcCtx.GRPCDialNode(addr.String(), node.NodeID, rpc.DefaultClass).ConnectNoBreaker(ctx)
if err != nil {
if grpcutil.IsClosedConnection(err) {
log.Infof(ctx, "can't dial node n%d because connection is permanently closed: %s",
node.NodeID, err)
return err
}
// Retry any other transient connection flakes.
continue
}
client := serverpb.NewStatusClient(conn)
err = visitor(client)
if err == nil {
return nil
}
log.Infof(ctx, "failed calling a visitor for node n%d: %s", node.NodeID, err)
if !IsRetryableError(err) {
return err
}
}
return err
}
}
func allNodes(roachpb.NodeID) bool {
return true
}
func onlyListed(nodes map[roachpb.NodeID]bool) func(id roachpb.NodeID) bool {
return func(id roachpb.NodeID) bool {
return nodes[id]
}
}
func notListed(ids []roachpb.NodeID) func(id roachpb.NodeID) bool {
ignored := make(map[roachpb.NodeID]bool)
for _, id := range ids {
ignored[id] = true
}
return func(id roachpb.NodeID) bool {
return !ignored[id]
}
}