Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have the ability to filter out internal queries when using sql.log.user_audit cluster setting #105590

Open
smcvey opened this issue Jun 26, 2023 · 2 comments
Open

Have the ability to filter out internal queries when using sql.log.user_audit cluster setting #105590

smcvey opened this issue Jun 26, 2023 · 2 comments
Assignees
@kevin-v-ngo
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-3 Issues/test failures with no fix SLA T-observability

Comments

@smcvey
Copy link
Contributor

smcvey commented Jun 26, 2023 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.
When using sql.log.user_audit, the audit log records ALL queries generated by the user, even ones that are internally created by viewing the DBConsole etc. There should be an option to only record explicit SQL queries ran externally from clients.

Describe the solution you'd like
A new cluster setting, which works with sql.log.user_audit to disable the logging of anything where the query is generated internally (e.g. ApplicationName is one of $ internal-console, $ internal-check-is-admin, etc.

Jira issue: CRDB-29113
@smcvey smcvey added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jun 26, 2023
@smcvey
Copy link
Contributor Author

smcvey commented Jun 27, 2023

The suppression of internal events doesn't necessarily have to be for the sql.log.user_audit option only, that was just an example. It can gave a wider scope if necessary to include all forms of auditing.

@kevin-v-ngo kevin-v-ngo self-assigned this Jun 27, 2023
@THardy98
Copy link
Contributor

Related: #107282

Still need to filter out other internal queries (i.e. the console)

@smcvey smcvey added the O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs label May 16, 2024
@dhartunian dhartunian added the P-3 Issues/test failures with no fix SLA label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin-v-ngo kevin-v-ngo

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-3 Issues/test failures with no fix SLA T-observability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dhartunian @THardy98 @smcvey @kevin-v-ngo