Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: disable metamorphic testing for mixed version test #112624

Merged

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Oct 18, 2023

We've seen that these tests can get quite slow sometimes. One theory is that this is caused by metamorphic test settings, so this PR disables them so we can determine if it helps with test stability.

informs #112621
Release note: None

We've seen that these tests can get quite slow sometimes. One theory is
that this is caused by metamorphic test settings, so this PR disables
them so we can determine if it helps with test stability.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt, @RaduBerinde, @renatolabs, and @yuzefovich)

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

No backport yet - you're thinking of letting this take effect on master for some time but backport later if necessary?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @dt, @RaduBerinde, and @renatolabs)

@rafiss
Copy link
Collaborator Author

rafiss commented Oct 18, 2023

No backport yet - you're thinking of letting this take effect on master for some time but backport later if necessary?

i think this should be an uncontroversial backport. even if it doesn't help with the flakes, i don't see any reason why we want this test to be metamorphic.

tftr!

bors r+

@rafiss rafiss added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Oct 18, 2023
@craig
Copy link
Contributor

craig bot commented Oct 18, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 18, 2023

Build succeeded:

@craig craig bot merged commit 2cb7c2a into cockroachdb:master Oct 18, 2023
8 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Oct 18, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 48eceb7 to blathers/backport-release-23.1-112624: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rafiss rafiss deleted the logictest-mixed-version-disable-metamorphic branch October 18, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants