Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colexec: negative length supplied to makeslice #118724

Closed
cockroach-teamcity opened this issue Feb 3, 2024 · 6 comments · Fixed by #118679
Closed

colexec: negative length supplied to makeslice #118724

cockroach-teamcity opened this issue Feb 3, 2024 · 6 comments · Fixed by #118679
Assignees
@yuzefovich
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator P-2 Issues/test failures with a fix SLA of 3 months T-sql-queries SQL Queries Team
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Feb 3, 2024 •
edited by cockroach-jira-scripts
Loading

roachtest.sqlsmith/setup=rand-tables/setting=no-ddl failed with artifacts on master @ 15961a19faca0e2b66df2d01a547549523ca70c7:

(sqlsmith.go:271).func3: error: pq: internal error: unexpected error from the vectorized engine: runtime error: makeslice: len out of range
stmt:
SELECT
	"Tab_4808".col5__1 AS col_8294,
	tab_4807."col2_ _4" AS "col%_8295",
	string_agg(e'\U0004CADF\U000B2D83\U0006135A\U0009ACF5\U000E8324\U00030218\U000816B3\U0007DA00\U000751FD' COLLATE en_US::STRING, e'\U000DAE6D\U000BECD8\U000DF84C\U000B57C6\U00027DAD\U000C122E\U000DBE49' COLLATE en_US::STRING)::STRING COLLATE en_US
		AS "\\xc1c'ol_8296"
FROM
	defaultdb.public."%vtable_2"@[0] AS tab_4807, defaultdb.public.table_5@[0] AS "Tab_4808"
GROUP BY
	tab_4807."col2_ _4", "Tab_4808".col5__1, tab_4807.col2__1
HAVING
	bool_and(false::BOOL)::BOOL;
test artifacts and logs in: /artifacts/sqlsmith/setup=rand-tables/setting=no-ddl/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-35865
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator T-sql-queries SQL Queries Team labels Feb 3, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Feb 3, 2024
@DrewKimball
Copy link
Collaborator 

E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663  encountered internal error:
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +unexpected error from the vectorized engine: runtime error: makeslice: len out of range
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +(1) assertion failure
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +Wraps: (2) attached stack trace
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  -- stack trace:
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError.func1
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:89
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | runtime.gopanic
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	GOROOT/src/runtime/panic.go:914
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | runtime.panicmakeslicelen
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	GOROOT/src/runtime/slice.go:29
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | runtime.makeslice
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	GOROOT/src/runtime/slice.go:98
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecagg.(*AggregateFuncsAlloc).MakeAggregateFuncs
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecagg/aggregate_funcs.go:569
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec.(*hashAggregator).onlineAgg
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/hash_aggregator.go:431
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec.getNext_false
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/colexec/hash_aggregator.eg.go:585
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec.(*hashAggregator).Next
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/colexec/hash_aggregator.eg.go:90
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecdisk.(*diskSpillerBase).Next.func1
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecdisk/disk_spiller.go:202
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:92
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecdisk.(*diskSpillerBase).Next
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecdisk/disk_spiller.go:200
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecutils.(*selBoolOp).Next
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecutils/bool_vec_to_sel.go:142
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecutils.(*BoolVecToSelOp).Next
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecutils/bool_vec_to_sel.go:62
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecbase.(*simpleProjectOp).Next
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecbase/simple_project.go:124
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec.(*allSpooler).spool
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/sort.go:136
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec.(*sortOp).Next
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/sort.go:280
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecdisk.(*diskSpillerBase).Next.func1
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecdisk/disk_spiller.go:202
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:92
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecdisk.(*diskSpillerBase).Next
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecdisk/disk_spiller.go:200
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecbase.(*simpleProjectOp).Next
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecbase/simple_project.go:124
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colflow.(*BatchFlowCoordinator).nextAdapter
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:250
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:92
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colflow.(*BatchFlowCoordinator).next
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:254
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colflow.(*BatchFlowCoordinator).Run
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:286
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql/colflow.(*vectorizedFlow).Run
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colflow/vectorized_flow.go:320
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).Run
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:910
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRun
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1971
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRunAll.func3
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1686
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRunAll
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1689
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithDistSQLEngine
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:2420
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1949
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1125
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +Wraps: (3) unexpected error from the vectorized engine
E240203 21:07:36.058566 2332 sql/sqltelemetry/report.go:57 ⋮ [T1,Vsystem,n1,client=34.145.152.208:56610,hostnossl,user=root] 233663 +Wraps: (4) runtime error: makeslice: len out of range

@DrewKimball
Copy link
Collaborator

Looks like fallout from #118556. Since the alloc size is capped, probably we're somehow getting a negative value.

@DrewKimball DrewKimball added the P-2 Issues/test failures with a fix SLA of 3 months label Feb 4, 2024
@DrewKimball DrewKimball changed the title roachtest: sqlsmith/setup=rand-tables/setting=no-ddl failed colexec: negative length supplied to makeslice Feb 4, 2024
This was referenced Feb 4, 2024
Closed
Closed
@DrewKimball
Copy link
Collaborator

Dupe of #118724

This was referenced Feb 5, 2024
Closed
Closed
@yuzefovich
Copy link
Member

Wait, Drew you closed this issue as a dup of itself 😄

This might be the overflow bug I'm fixing in #118679.

@yuzefovich yuzefovich reopened this Feb 5, 2024
@yuzefovich yuzefovich self-assigned this Feb 5, 2024
@yuzefovich yuzefovich mentioned this issue Feb 5, 2024
Merged
@yuzefovich
Copy link
Member

Indeed, in all failures we see something like estimated row count: -9,223,372,036,854,775,808 for the hash aggregation, so #118679 should fix it.

That said, negative estimated row count should probably be never created by the optimizer in the first place.

@mgartner
Copy link
Collaborator

mgartner commented Feb 5, 2024

Wait, Drew you closed this issue as a dup of itself 😄

Sounds like an efficient way to close test failures. I need to remember that one!

@yuzefovich yuzefovich mentioned this issue Feb 5, 2024
Closed
@craig craig bot closed this as completed in aee73ac Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator P-2 Issues/test failures with a fix SLA of 3 months T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

sql: minor improvements around estimated row count yuzefovich/cockroach
4 participants
@mgartner @yuzefovich @cockroach-teamcity @DrewKimball