roachtest: regenerate BACKUP fixtures for TPCC/TPCH tests #120146
Labels
A-testing
Testing tools and infrastructure
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-testeng
TestEng Team
Comments
rafiss
added
C-enhancement
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
cc @cockroachdb/test-eng |
craig bot
pushed a commit
that referenced
this issue
Mar 8, 2024
120097: sql: mark implicit transactions with AOST as read-only r=yuzefovich,rafiss a=michae2 **sql: mark implicit transactions with AOST as read-only** In `handleAOST` we were setting the transaction AOST but not marking it as read-only. It needs to also be marked as read-only to disallow mutation statements and locking statements. Fixes: #120081 Release note (sql change): Mutation statements such as UPDATE and DELETE as well as locking statements such as SELECT FOR UPDATE are not allowed in read-only transactions or AS OF SYSTEM TIME transactions. Fix an oversight where we were allowing mutation statements and locking statements in implicit single-statement transactions using AS OF SYSTEM TIME. --- **sql: disallow SET transaction_read_only = false during AOST txn** Fixes: #44200 Release note (bug fix): Fix a bug in which it was possible to `SET transaction_read_only = false` during an AS OF SYSTEM TIME transaction. 120147: catalog: add maybeAddConstraintIDs to RestoreChanges r=rafiss a=rafiss This partially reverts 8b56efd All backups taken in versions 22.1 and later should already have constraint IDs set. Technically, now that we are in v24.1, we no longer support restoring from versions older than 22.1, but we still have tests that restore from old versions. Until those fixtures are updated, we need to handle the case where constraint IDs are not set already when restoring a backup. To prove that this works, I've resurrected a different test that restores from a v21.1 backup, which was earlier deleted in 8b56efd. informs #120146 Release note: None 120148: tests: move some tests to `heavy` pools in `race`, `deadlock` r=rail a=rickystewart Epic: CRDB-8308 Release note: None Co-authored-by: Michael Erickson <michae2@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this thread, we realized that TPCC and TPCH test fixtures use backups that are several years old: https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1709912020888919?thread_ts=1709896031.584779&cid=C023S0V4YEB
We no longer support restoring from backups taken from more than 1 major version ago. (Or 2, if we're in a branch that supports version skipping.)
We should regenerate the fixtures.
#120124 is an example of a failure that was caused by this, with many other issues linked to it.
#120147 works around this issue by adding a post-restore descriptor change, so tests stop failing, but we still should tackle this tech debt and update the fixtures.
Jira issue: CRDB-36509
The text was updated successfully, but these errors were encountered: