-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/partitionccl: TestInitialPartitioning failed under stress [skipped] #28789
Comments
SHA: https://github.com/cockroachdb/cockroach/commits/88fd66dea46c2fbdb24c3f225a817ea806808ffa Parameters:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=847351&tab=buildLog |
SHA: https://github.com/cockroachdb/cockroach/commits/c74df43ba18345c48c685e899e2f4ef9785aef34 Parameters:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=848724&tab=buildLog |
SHA: https://github.com/cockroachdb/cockroach/commits/c74df43ba18345c48c685e899e2f4ef9785aef34 Parameters:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=849178&tab=buildLog |
cc cockroachdb#28789 and cockroachdb#28786 Release note: None
28814: sql: remove the broken support for BIT r=knz a=knz Part of #28690. This is a prior PR to #28807. I foresee that the other PR will need some iteration (and perhaps some consensus gathering) and may merge later in the 2.2 cycle. In the meantime we need to remove the brokenness from client apps. This PR disables the BIT type (in a backward-compatible manner!) until we can actually address #20991. ----- Previously CockroachDB was handling the keyword BIT as an alias for INT (specifically: INT with a "visible type" of BIT). With regards to storing values, performing arithmetic, comparisons, etc, "BIT" values were considered just integers. In the PostgreSQL dialect however, bit arrays are a completely different thing: they are arbitrary long strings of bits, possibly longer (or shorter) than 64 bits, with odd number of bits, etc. They use different literal formats, have different semantics for arithmetic and concatenation, etc. Unfortunately, this mismatch confuses clients that either want to use the pg BIT semantics, or do introspection (e.g. ORMs). To prevent this confusion, this patch removes the broken support for BIT until proper support is actually introduced. Now clients that attempt to use the BIT keyword will see an unimplemented feature error linking back to issue #20991. As uninmplemented errors are also reported, we will be able to track demand for it. Release note (backward-incompatible change): CockroachDB previously included some preliminary support for the data type "BIT". Unfortunately this functionality was both incorrectly implemented and was found to cause incompatibility with client apps. It is thus removed; it will be replaced by a PostgreSQL-compatible replacement at a later time. Release note (sql change): Tables columns created prior to this patch with the type name "BIT" will continue to work but will see their type automatically changed to INT in the output of SHOW TABLES, `information_schema`, etc. This is backward-compatible insofar that the previous BIT type in CockroachDB was actually a simple integer. Only the name of the type of these columns changes; their values are unaffected and can continue to be used in queries without visible changes to query results in client apps which actually utilized the incorrect pre-2.1 BIT semantics. 28863: partitionccl: Skip flaky partitioning tests r=a-robinson a=a-robinson cc #28789 and #28786 Release note: None These have been failing like crazy the last few days. We should of course fix them, but I'm tired of seeing new issues filed about them every few hours. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com> Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>
Did a bit of initial triage to check if this was still an issue. Found a panic in BitArray.Format (#31115) and then managed to get TestInitialPartitioning/single_col_list_partitioning_-_DEFAULT to timeout after 8 minutes. There were all sorts of the following in the logs
I think the
Here's (hopefully) an interesting prefix of the test logs
|
I saw the |
Assigning to @tschottdorf for triage |
Long time no fail. |
Heh, because it's skipped. This really needs to be fixed. Essentially our entire test coverage of partitioning (this plus TestRepartitioning) is skipped. |
Ugh. Thanks for noticing. |
@petermattis could you take a look at this? |
Looking. So far I'm unable to reproduce (and yes, I've unskipped the test). I did have to fix the test cases to avoid using |
Just didn't run long enough:
|
The failure I'm seeing is that verification that a scan is taking place on a particular node is not occurring. In particular, the test is failing this query for 45s:
The logs shows that partitioning did split the table at the specified key (
So the test is complaining that the scan did not complete on |
Avoid creating test cases with an `ARRAY` column as the primary key. Unify the handling of non-indexable column types for test case generation (`ARRAY`, `JSONB` and `TUPLE`). Adjust `verifyScansOnNode` to skip `read completed` trace lines for the system config range. Reads can be performed on this range to renew the table lease and we want to ignore those reads for the purposes of the test. Fixes cockroachdb#28786 Fixes cockroachdb#28789 Release note: None
Avoid creating test cases with an `ARRAY` column as the primary key. Unify the handling of non-indexable column types for test case generation (`ARRAY`, `JSONB` and `TUPLE`). Adjust `verifyScansOnNode` to skip `read completed` trace lines for the system config range. Reads can be performed on this range to renew the table lease and we want to ignore those reads for the purposes of the test. Fixes cockroachdb#28786 Fixes cockroachdb#28789 Release note: None
33409: ccl/partitionccl: re-enable Test{InitialPartitioning,Repartitioning} r=benesch a=petermattis Avoid creating test cases with an `ARRAY` column as the primary key. Unify the handling of non-indexable column types for test case generation (`ARRAY`, `JSONB` and `TUPLE`). Adjust `verifyScansOnNode` to skip `read completed` trace lines for the system config range. Reads can be performed on this range to renew the table lease and we want to ignore those reads for the purposes of the test. Fixes #28786 Fixes #28789 Release note: None Co-authored-by: Peter Mattis <petermattis@gmail.com>
33409: ccl/partitionccl: re-enable Test{InitialPartitioning,Repartitioning} r=benesch a=petermattis Avoid creating test cases with an `ARRAY` column as the primary key. Unify the handling of non-indexable column types for test case generation (`ARRAY`, `JSONB` and `TUPLE`). Adjust `verifyScansOnNode` to skip `read completed` trace lines for the system config range. Reads can be performed on this range to renew the table lease and we want to ignore those reads for the purposes of the test. Fixes #28786 Fixes #28789 Release note: None Co-authored-by: Peter Mattis <petermattis@gmail.com>
SHA: https://github.com/cockroachdb/cockroach/commits/8bd6caec6eed07ecff29801f3f11993352544387
Parameters:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=846134&tab=buildLog
The text was updated successfully, but these errors were encountered: