Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamcity/example-orms: example-orms isn't a pinned revision when running CI #42083

Closed
irfansharif opened this issue Oct 31, 2019 · 3 comments
Closed
Labels
A-testing Testing tools and infrastructure T-dev-inf

Comments

@irfansharif
Copy link
Contributor

irfansharif commented Oct 31, 2019

#42042, a backport to release-v2.1 was failing on TC due to Example ORM tests. Debugging that I noticed that our TC setup does not use a pinned revision of example-orms when running the test suite (it simply picks up whatever is on master). This means that any and every change pushed out to https://github.com/cockroachdb/examples-orms is what gets used for all future TC runs against all branches (including all the way back to release-v2.1). This is probably not what we want (#42042 (comment)).

Jira issue: CRDB-5389

@irfansharif irfansharif added the A-testing Testing tools and infrastructure label Oct 31, 2019
@irfansharif
Copy link
Contributor Author

+cc @rohany, @rafiss for triage.

@kenliu
Copy link

kenliu commented Mar 18, 2020

@apantel I think this is related to the work you are doing with pinning versions

@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@rafiss rafiss added T-dev-inf and removed T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jun 20, 2023
@rafiss
Copy link
Collaborator

rafiss commented Jul 27, 2023

I don't think we'll prioritize this work. For the past few years, this issue hasn't caused much disruption. The way we workaround it is to teach examples-orms about which CRDB versions various tests are expected to work with. Example: https://github.com/cockroachdb/examples-orms/blob/1e65311aeebffed07371d258bfcf7fbe4abf01c8/testing/main_test.go#L191-L194

@rafiss rafiss closed this as completed Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure T-dev-inf
Projects
None yet
Development

No branches or pull requests

5 participants