sql: remove unnecessary casts in @@ operator type-checking
#100704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
12 tasks
Release note: None
mgartner
force-pushed
the
tmp-remove-tsquery-casts
branch
from
7cfbd81
to
ec95acf
Compare
msirek
approved these changes
Apr 5, 2023
complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build failed: |
|
Looks like a flake. bors r+ |
|
Build succeeded: |
mgartner
added a commit
to mgartner/cockroach
that referenced
this pull request
May 31, 2023
This commit fixes a comment that has been outdated since cockroachdb#100704. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
104142: sql: fix comment and remove TODO r=mgartner a=mgartner #### opt: remove unnecessary TODO This commit removes a TODO that was addressed in #95638. Release note: None #### sql: fix comment in type_check.go This commit fixes a comment that has been outdated since #100704. Epic: None Release note: None Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: None
Release note: None