roachtest: categorise post-test assertions separately #103946
Conversation
|
This change is |
smg260
changed the title
|
I was in 2 minds about perhaps keeping the post-test logging in the primary |
smg260
requested review from
srosenberg,
renatolabs and
herkolategan
and removed request for
a team
There was a problem hiding this comment.
Nice change! Just some small nits about maybe using a switch for category/failure. I like the log separation, so I'm glad you chose to go with that.
Reviewed 5 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @renatolabs, @smg260, and @srosenberg)
pkg/cmd/roachtest/github.go line 122 at r1 (raw file):
var infraFlake bool // Overrides to shield eng teams from potential flakes if cat == clusterCreationErr {
Nit: switch statement might give this a cleaner look.
smg260
force-pushed
the
98366_teardown_errors
branch
2 times, most recently
from
f1c492d
to
0821d4b
Compare
|
Will merge after this nightly roachtest completes. |
smg260
force-pushed
the
98366_teardown_errors
branch
from
0821d4b
to
d4d6679
Compare
Epic: none Fixes: cockroachdb#98366 Release note: None
Every test, unless opted-out, runs various post validations such as node liveness and consistency checks. Failures that occur here are now logged to a separate file, and indicated as such in github when an issue is created. Previously, these checks were done during teardown and logged to the teardown.log.
smg260
force-pushed
the
98366_teardown_errors
branch
from
d4d6679
to
432909c
Compare
|
bors r=herkolategan TFTR |
|
bors r- |
|
Canceled. |
|
bors r+ single on p=999 |
|
Build failed: |
|
bors retry single on p=999 |
|
Build failed: |
|
the build posted by craig actually succeeded, despite it claming otherwise... bors is messed up bors retry |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
roachtest: categorise post-test assertion errors separately
Simple change to mark failures that occur in post-test validation (teardown), so that we can more clearly report a test that has experience a failure after its execution has ended.
Every test, unless opted-out, runs various post validations such as node liveness and consistency checks. These checks have been moved to their own function, and failures that occur here are now logged to a separate file, and indicated as such in github when an issue is created.
Previously, these checks were done during teardown and logged to the teardown.log.
Epic: none
Fixes: #98366
Release note: None