Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlproxyccl: simplify NewSubStopper #107316

Merged

Conversation

jeffswenson
Copy link
Collaborator

The lock in NewSubStopper caused lock ordering warnings when run under deadlock detection. The justification given for the lock's existence is wrong. If a closer is added to an already stopped stopper, the closer is called immediately.

Release note: None
Part of: #106571

The lock in NewSubStopper caused lock ordering warnings when run under
deadlock detection. The justification given for the lock's existence is
wrong. If a closer is added to an already stopped stopper, the closer is
called immediately.

Release note: None
Fixes: cockroachdb#106571
@jeffswenson jeffswenson requested review from a team as code owners July 20, 2023 22:08
@blathers-crl
Copy link

blathers-crl bot commented Jul 20, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jeffswenson jeffswenson added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Jul 20, 2023
@jaylim-crl jaylim-crl requested a review from darinpp July 22, 2023 02:59
Copy link
Collaborator

@jaylim-crl jaylim-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @darinpp)

@jeffswenson
Copy link
Collaborator Author

bors r+

1 similar comment
@jeffswenson
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 1, 2023

Build succeeded:

@craig craig bot merged commit 509f8c8 into cockroachdb:master Aug 1, 2023
2 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Aug 1, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-107316 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/107972/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants