Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: Fix test data race #110215

Merged
merged 1 commit into from
Sep 8, 2023
Merged

changefeedccl: Fix test data race #110215

merged 1 commit into from
Sep 8, 2023

Conversation

miretskiy
Copy link
Contributor

Fixes #110155

Release note: None

@miretskiy miretskiy requested a review from a team as a code owner September 7, 2023 20:45
@miretskiy miretskiy requested review from HonoreDB and removed request for a team September 7, 2023 20:45
@blathers-crl
Copy link

blathers-crl bot commented Sep 7, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

amruss
amruss approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@amruss amruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 8, 2023

Build succeeded:

@craig craig bot merged commit 1184f96 into cockroachdb:master Sep 8, 2023
3 checks passed
@miretskiy miretskiy mentioned this pull request Sep 8, 2023
Closed
@jayshrivastava
Copy link
Contributor

blathers backport 23.1

@blathers-crl blathers-crl bot mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amruss amruss amruss approved these changes

@HonoreDB HonoreDB Awaiting requested review from HonoreDB HonoreDB is a code owner automatically assigned from cockroachdb/cdc-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ccl/changefeedccl: TestChangefeedLaggingRangesMetrics failed
4 participants
@miretskiy @cockroach-teamcity @jayshrivastava @amruss