Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: cloud/azure: Fix azure schemes #111286

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

benbardin
Copy link
Collaborator

@benbardin benbardin commented Sep 26, 2023

Backport 1/1 commits from #111217.

/cc @cockroachdb/release


Part of: https://cockroachlabs.atlassian.net/browse/CRDB-31120

Release note (bug fix): Fixes azure schemes in storage and external conns.

Release justification: bugfix

@benbardin benbardin requested a review from a team as a code owner September 26, 2023 17:21
@blathers-crl
Copy link

blathers-crl bot commented Sep 26, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 26, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Part of: https://cockroachlabs.atlassian.net/browse/CRDB-31120

Release note (bug fix): External connection URLs now accept the scheme
`azure-blob` for connections to Azure Blob Storage. For backward compatibility,
schemes `azure` and `azure-storage` schemes continue to work.
@benbardin
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 27, 2023

Build succeeded:

@craig craig bot merged commit 767306c into cockroachdb:release-22.2 Sep 27, 2023
6 of 7 checks passed
@benbardin benbardin deleted the backport22.2-111217 branch September 28, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants