Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore: remove disabled experimental monitored mode #119926

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

dt
Copy link
Member

@dt dt commented Mar 5, 2024

We never got this over the finish line and given our shift in priorities and future direction in restore investment from above-raft to below-raft restores, this seems unlikely to be enabled, so removing it reduces the complexity in the code we need to maintain until below-raft restores replace it.

Release note: none.
Epic: none.

@dt dt requested review from stevendanna and msbutler March 5, 2024 13:59
@dt dt requested review from a team as code owners March 5, 2024 13:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

We never got this over the finish line and given our shift in priorities
and future direction in restore investment from above-raft to below-raft
restores, this seems unlikely to be enabled, so removing it reduces the
complexity in the code we need to maintain until below-raft restores
replace it.

Release note: none.
Epic: none.
@dt
Copy link
Member Author

dt commented Mar 5, 2024

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 6, 2024

Build succeeded:

@craig craig bot merged commit 14f433f into cockroachdb:master Mar 6, 2024
17 of 18 checks passed
@dt dt deleted the mem-restore branch March 6, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants