Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: update cache size for on-disk logictest configs #120005

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 6, 2024

The default cache size is 128MB. This can result in disk-related slowdowns for normal operations. Now we configure a larger cache so that we avoid disk access.

fixes #119897
Release note: None

The default cache size is 128MB. This can result in a lot of
disk-related slowdowns for normal operations. Now we configure a larger
cache so that we avoid disk access.

Release note: None
@rafiss rafiss requested review from fqazi and a team March 6, 2024 17:58
@rafiss rafiss requested a review from a team as a code owner March 6, 2024 17:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

@rafiss
Copy link
Collaborator Author

rafiss commented Mar 6, 2024

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 6, 2024

Build succeeded:

@craig craig bot merged commit 82eb30e into cockroachdb:master Mar 6, 2024
17 of 18 checks passed
@rafiss rafiss deleted the fix-logictest-testserver-cache branch March 6, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catalog/lease: timeout during lease acquisition
4 participants