Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: colexec: fix evaluation of the IN expression with INT2 and INT4 types #121955

Merged

Commits on Apr 8, 2024

  1. colexec: fix evaluation of the IN expression with INT2 and INT4 types

    This commit fixes a possible incorrect result of evaluation of the IN
    expression where the left side is INT2 or INT4 type and the right side
    has integers outside of the range of the left side's type. We do so by
    upcasting the "filter" row to INT8. Note that we already do the
    appropriate upcast in the comparison function, so the incorrect results
    could only be produced due to the "filter row" no longer being sorted in
    case a value overflows.
    
    Release note (bug fix): CockroachDB could previously incorrectly
    evaluate IN expressions that had INT2 or INT4 type on the left side and
    values outside of the range of the left side on the right side. The bug
    has been present since at least 21.1 and is now fixed.
    yuzefovich committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    918dd72 View commit details
    Browse the repository at this point in the history