Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: allocator: remove log.VEventf for alive stores in isStoreReady… #122381

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 15, 2024

Backport 1/1 commits from #107420 on behalf of @wenyihu6.

/cc @cockroachdb/release


When investigating an allocator simulator test, we observed a significant amount
of time spent by log.VEventf, consuming 64% of time (according to pprof CPU
analysis). This was mainly caused by rankedCandidateListForRebalancing
repeatedly calling IsStoreReadyForRoutineReplicaTransfer on all stores that
pass the StoreFilterThrottled filter. As a temporary mitigation, we deleted
log.VEventf in isStoreReadyForRoutineReplicaTransferInternal for less
interesting cases where stores are alive. However, our longer term strategy is
to buffer such outputs in the allocator at a higher level to reduce
log.VEventf calls.

Informs: #107421

Release note: None


Before After
Screenshot 2023-07-21 at 6 08 01 PM Screenshot 2023-07-22 at 11 08 33 PM

Release justification: Removes significant logging overhead in clusters with a large number of stores.

…ineReplicaTransferInternal

When investigating an allocator simulator test, we observed a significant amount
of time spent by `log.VEventf`, consuming 64% of time (according to pprof CPU
analysis). This was mainly caused by `rankedCandidateListForRebalancing`
repeatedly calling `IsStoreReadyForRoutineReplicaTransfer` on all stores that
pass the `StoreFilterThrottled` filter. As a temporary mitigation, we deleted
`log.VEventf` in `isStoreReadyForRoutineReplicaTransferInternal` for less
interesting cases where stores are alive.  However, our longer term strategy is
to buffer such outputs in the allocator at a higher level to reduce
`log.VEventf` calls.

Related: #107421

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 15, 2024 19:48
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107420 branch from 33212fa to 344a490 Compare April 15, 2024 19:48
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 15, 2024
@blathers-crl blathers-crl bot requested a review from kvoli April 15, 2024 19:48
Copy link
Author

blathers-crl bot commented Apr 15, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 15, 2024
Copy link
Author

blathers-crl bot commented Apr 15, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@wenyihu6 wenyihu6 merged commit 70cdbe2 into release-23.1 Apr 19, 2024
6 checks passed
@wenyihu6 wenyihu6 deleted the blathers/backport-release-23.1-107420 branch April 19, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants