roachprod: add install cmd for side-eye #123974
Conversation
|
This change is |
This also required a new optional extra map of local -- to the client running roachprod -- commands that can be run to replace arguments in the install cmd, so that we can get the key without checking it in. Alternateively we could special-case the side-eye install in go code but this felt more generalized. Release note: none. Epic: none.
| @@ -93,6 +97,19 @@ echo "deb [signed-by=/etc/apt/keyrings/fluent-bit.gpg] https://packages.fluentbi | |||
| sudo apt-get update; | |||
| sudo apt-get install -y fluent-bit; | |||
| `, | |||
|
|
|||
| "side-eye": ` | |||
There was a problem hiding this comment.
could you write a docstring here that lays out how to install side eye? this could also go in the commit message. i.e. i think it is something like, but it's not totally clear from the code:
roachprod install $CLUSTER side-eye --secret $API_KEY
There was a problem hiding this comment.
It is just roachprod install TARGET side-eye same as all the others, eg roachprod install TARGET haproxy. Given it is consistent with all the other install commands it seems weird to give it special documentation?
There was a problem hiding this comment.
Ah, so the user needs to set the SIDE_EYE_API_TOKEN env var. I think that's worth documenting.
There was a problem hiding this comment.
i'm just thinking through ways to ease the onboarding process for any CRL engineer.
There was a problem hiding this comment.
Ah, so the user needs to set the
SIDE_EYE_API_TOKENenv var. I think that's worth documenting.
No, the key is fetched from gcloud (which you already need to have configured to use roachprod); the user with keys on keyboard never touches the key.
There was a problem hiding this comment.
i'm just thinking through ways to ease the onboarding process for any CRL engineer.
Again, it is identical to all the other install commands, which seems like it should be as easy as we can do
There was a problem hiding this comment.
I see, sorry, was not reading the code as closely as I could have.
|
TFTR! bors r+ |
|
Build failed: |
|
brutal preemptions bors r+ |
This also required a new optional extra map of local -- to the client running roachprod -- commands that can be run to replace arguments in the install cmd, so that we can get the key without checking it in.
Alternateively we could special-case the side-eye install in go code but this felt more generalized.
Release note: none.
Epic: none.