Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: fix maxWaitDuration in lease-preferences #124034

Merged
merged 1 commit into from
May 13, 2024
Merged

roachtest: fix maxWaitDuration in lease-preferences #124034

merged 1 commit into from
May 13, 2024

Conversation

nvanbenschoten
Copy link
Member

Informs #123998.

The attempt to limit how long waitForLeasePreferences was broken.

Release note: None

@nvanbenschoten
roachtest: fix maxWaitDuration in lease-preferences
37510f2 
Informs cockroachdb#123998.

The attempt to limit how long waitForLeasePreferences was broken.

Release note: None
@nvanbenschoten nvanbenschoten requested a review from kvoli May 13, 2024 13:00
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner May 13, 2024 13:00
@nvanbenschoten nvanbenschoten requested review from nameisbhaskar and vidit-bhat and removed request for a team May 13, 2024 13:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten mentioned this pull request May 13, 2024
Closed
@nvanbenschoten nvanbenschoten added the backport-24.1.x Flags PRs that need to be backported to 24.1. label May 13, 2024
kvoli
kvoli approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@kvoli kvoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is case <-time.After(...): broken here? This is used in quite a few other places e.g.

cockroach/pkg/server/drain.go

Line 220 in 9203985

case <-time.After(10 * time.Second):

@nvanbenschoten
Copy link
Member Author

It's broken because case <-time.After(...): is used in a for loop where the checkTimer fires every 10 seconds. So the time.After is reset every 10 seconds.

@kvoli
Copy link
Collaborator

kvoli commented May 13, 2024

It's broken because case <-time.After(...): is used in a for loop where the checkTimer fires every 10 seconds. So the time.After is reset every 10 seconds.

Ahh, my bad. Thanks for the explanation.

@nvanbenschoten
Copy link
Member Author

TFTR!

bors r=kvoli

@craig
Copy link
Contributor

craig bot commented May 13, 2024

Build succeeded:

@craig craig bot merged commit 264a264 into cockroachdb:master May 13, 2024
22 checks passed
@blathers-crl blathers-crl bot mentioned this pull request May 13, 2024
Merged
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/maxWait branch May 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvoli kvoli kvoli approved these changes

@nameisbhaskar nameisbhaskar Awaiting requested review from nameisbhaskar nameisbhaskar is a code owner automatically assigned from cockroachdb/test-eng

@vidit-bhat vidit-bhat Awaiting requested review from vidit-bhat vidit-bhat is a code owner automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvanbenschoten @cockroach-teamcity @kvoli