Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: bump timeout of failover/chaos tests #124035

Merged

Conversation

nvanbenschoten
Copy link
Member

Fixes #124030.

The test runs 20 iterations of failures, each of which include 3 sleeps, two of which take 1 minute. This is not quite enough time so the test occasionally times out when it is otherwise making progress.

Release note: None

Fixes cockroachdb#124030.

The test runs 20 iterations of failures, each of which include 3 sleeps,
two of which take 1 minute. This is not quite enough time so the test
occasionally times out when it is otherwise making progress.

Release note: None
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner May 13, 2024 13:23
@nvanbenschoten nvanbenschoten requested review from nameisbhaskar and vidit-bhat and removed request for a team May 13, 2024 13:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten added backport-24.1.x Flags PRs that need to be backported to 24.1. backport-23.2.x Flags PRs that need to be backported to 23.2. labels May 13, 2024
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nvanbenschoten
Copy link
Member Author

TFTR!

bors r+

@craig craig bot merged commit 28bce06 into cockroachdb:master May 15, 2024
22 checks passed
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/chaosTimeout branch May 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: failover/chaos/read-write failed
3 participants