-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: kvstreamer: improve logging a bit #124092
release-24.1: kvstreamer: improve logging a bit #124092
Conversation
This commit adjusts the logging for each `singleRangeBatch` to include the number of scans inside of it (we only included the number of gets previously). It also drops the bitmap for whether the scans were started (this doesn't seem that useful - `positions` slice kinda implicitly has that information). Additionally, it includes the TargetBytes limit that each BatchRequest was issued with into an existing log message (we have this information down at the KV level too, but it makes things easier when grepping from streamer logs specifically). Release note: None
1d91ff3
to
54b201d
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Backport 1/1 commits from #124090 on behalf of @yuzefovich.
/cc @cockroachdb/release
This commit adjusts the logging for each
singleRangeBatch
to include the number of scans inside of it (we only included the number of gets previously). It also drops the bitmap for whether the scans were started (this doesn't seem that useful -positions
slice kinda implicitly has that information).Additionally, it includes the TargetBytes limit that each BatchRequest was issued with into an existing log message (we have this information down at the KV level too, but it makes things easier when grepping from streamer logs specifically).
Informs: https://github.com/cockroachlabs/support/issues/2945.
Epic: None
Release note: None
Release justification: low-risk improvement.