Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamproducer: add emit_wait and produce_wait to vtable #125369

Merged
merged 2 commits into from
Jun 10, 2024
Merged

streamproducer: add emit_wait and produce_wait to vtable #125369

merged 2 commits into from
Jun 10, 2024

Conversation

dt
Copy link
Member

@dt dt commented Jun 8, 2024

Release note: none.
Epic: none.

@dt dt requested a review from msbutler June 8, 2024 13:15
@dt dt requested review from a team as code owners June 8, 2024 13:15
@dt dt requested review from nkodali and removed request for a team June 8, 2024 13:15
@cockroach-teamcity
Copy link
Member

This change is Reviewable

stevendanna
stevendanna approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo in commit message: emit_eait -> emit_wait.

pkg/repstream/streampb/empty.go Show resolved Hide resolved
pkg/sql/crdb_internal.go Show resolved Hide resolved
@dt dt changed the title streamproducer: add emit_eait and produce_wait to vtable streamproducer: add emit_wait and produce_wait to vtable Jun 10, 2024
@dt
Copy link
Member Author

dt commented Jun 10, 2024

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 10, 2024

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 10, 2024

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 10, 2024

Build failed:

@dt
Copy link
Member Author

dt commented Jun 10, 2024

Looks like an annoyingly persistent but unrelated flake

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 10, 2024

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 10, 2024

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 10, 2024

Build failed:

@rickystewart
Copy link
Collaborator

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 10, 2024

Build succeeded:

@craig craig bot merged commit d554c0e into cockroachdb:master Jun 10, 2024
22 checks passed
@dt dt deleted the stream-timing branch June 11, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbutler msbutler msbutler approved these changes

@stevendanna stevendanna stevendanna approved these changes

@nkodali nkodali Awaiting requested review from nkodali nkodali is a code owner automatically assigned from cockroachdb/obs-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dt @cockroach-teamcity @rickystewart @stevendanna @msbutler