streamingccl: rename Create and Plan in client interface #125572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
force-pushed
the
butler-client-refactor
branch
from
a1029b0
to
818d011
Compare
|
unrelated flakes |
stevendanna
approved these changes
Jun 13, 2024
stevendanna
reviewed
Jun 13, 2024
| // Create implements Client interface. | ||
| func (p *partitionedStreamClient) Create( | ||
| // CreateForTenant implements Client interface. | ||
| func (p *partitionedStreamClient) CreateForTenant( | ||
| ctx context.Context, tenantName roachpb.TenantName, req streampb.ReplicationProducerRequest, | ||
| ) (streampb.ReplicationProducerSpec, error) { | ||
| ctx, sp := tracing.ChildSpan(ctx, "streamclient.Client.Create") |
stevendanna
reviewed
Jun 13, 2024
stevendanna
reviewed
Jun 13, 2024
… interface This patch renames Create to CreateForTenant and Plan to PlanPhysicalReplication in Client and PartitionSpans to PlanLogicalReplication in LogicalReplicationClieng to better destinguish which api calls relate to PCR vs LDR. Follow up work will move CreateForTenant and PlanPhysicalReplication into its own client interface wrapper for PCR. Epic: none Release note: none
This patch renames crdb_internal.partition_spans to crdb_internal.plan_logical_replication, and on replicationStreamManager, PartitionSpans to PlanLogicalReplication and GetReplicationStreamSpec to GetPhysicalReplicationStreamSpec. I intentionally did not rename crdb_internal.replication_stream_specover cross version compatability concerns. Epic: none Release note: none
msbutler
force-pushed
the
butler-client-refactor
branch
from
ea82dcf
to
46235d8
Compare
|
TFTR! bors r=stevendanna |
|
Build failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames Create to CreateForTenant and Plan to PlanPhysicalReplication to better destinguish which api calls relate to PCR vs LDR.
Follow up work will move CreateForTenant and PlanPhysicalReplication into its own client interface wrapper for PCR.
Epic: none
Release note: none