build: standardize make check and make install too
#16030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
benesch
changed the title
make check and make installmake check and make install too
To adhere to convention, have the `make install` target actually install the `cockroach` binary onto the PATH, namely into /usr/local/bin. Additionally expose the standard `prefix` and `DESTDIR` variables. The current behavior of `make install`--installing into $GOPATH/bin--is still exposed as `make go-install`. This new behavior is already the behavior of `make install` in the source tarball. Further addresses cockroachdb#15862.
To adhere to convention, turn `make check` into an alias for `make test`. Fixes cockroachdb#15862.
benesch
force-pushed
the
make-target-standardization
branch
from
1ece85b
to
d1e8dd4
Compare
|
Reviewed 2 of 2 files at r1, 2 of 2 files at r2. Comments from Reviewable |
knz
approved these changes
May 19, 2017
|
Review status: Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details. This (finally) addresses everything from #15862, I believe!
@bdarnell, this will break your workflow just a bit; you'll need
make go-installinstead ofmake installwith this patch.